fix: drop readable check

This check was introduced in a previous PR, causing disruptive
changes in PROPFIND responses in some cases.

Signed-off-by: Salvatore Martire <[email protected]>

Author: salmart-dev

apps/dav/lib/Connector/Sabre/Directory.php

@@ -531,15 +531,6 @@ public function getNodeForPath($path): INode {
 			throw new InvalidPath($ex->getMessage(), false, $ex);
 		}
 
-		// if not in a public share with no read permissions, throw Forbidden
-		if (!$allowDirectory && !$info->isReadable()) {
-			if (Server::get(IAppManager::class)->isEnabledForAnyone('files_accesscontrol')) {
-				throw new Forbidden('No read permissions. This might be caused by files_accesscontrol, check your configured rules');
-			}
-
-			throw new Forbidden('No read permissions');
-		}
-
 		if ($info->getMimeType() === FileInfo::MIMETYPE_FOLDER) {
 			$node = new \OCA\DAV\Connector\Sabre\Directory($this->fileView, $info, $this->tree, $this->shareManager);
 		} else {

apps/dav/tests/unit/Connector/Sabre/DirectoryTest.php

@@ -299,9 +299,6 @@ public function testGetNodeForPath(): void {
 		$pathNode->expects($this->once())
 			->method('getPath')
 			->willReturn('/admin/files/my/deep/folder/');
-		$pathNode->expects($this->once())
-			->method('isReadable')
-			->willReturn(true);
 		$pathNode->expects($this->once())
 			->method('getMimetype')
 			->willReturn(FileInfo::MIMETYPE_FOLDER);
@@ -352,9 +349,6 @@ public function testGetNodeForPathFailsWithNoReadPermissionsForParent(): void {
 		$pathNode->expects($this->once())
 			->method('getPath')
 			->willReturn('/admin/files/my/deep/folder/');
-		$pathNode->expects($this->once())
-			->method('isReadable')
-			->willReturn(true);
 		$pathNode->expects($this->once())
 			->method('getMimetype')
 			->willReturn(FileInfo::MIMETYPE_FOLDER);
@@ -393,21 +387,23 @@ public function testGetNodeForPathFailsWithNoReadPermissionsForPath(): void {
 			->method('instanceOfStorage')
 			->willReturn(false);
 
-		$directoryNode->expects($this->once())
+		$invokedCount = $this->exactly(2);
+		$directoryNode->expects($invokedCount)
 			->method('isReadable')
-			->willReturn(true);
+			->willReturnCallback(function () use ($invokedCount) {
+				return match ($invokedCount->numberOfInvocations()) {
+					1 => true,
+					2 => false,
+				};
+			});
 		$directoryNode->expects($this->once())
 			->method('getPath')
 			->willReturn('/admin/files/');
 		$directoryNode->expects($this->once())
 			->method('get')
 			->willReturn($pathNode);
 
-		$pathNode->expects($this->once())
-			->method('isReadable')
-			->willReturn(false);
-
-		$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
+		$this->expectException(\Sabre\DAV\Exception\NotFound::class);
 
 		$dir = new Directory($this->view, $directoryNode);
 		$dir->getNodeForPath('/my/deep/folder/');