fix(settings): improve mail test error handling and logging

- Use structured logging in MailSettingsController
- Show specific error response in admin.js
- Add styles for test email error messages

Signed-off-by: Abhinav Ohri <[email protected]>

Author: abhinavohri

apps/settings/css/settings.css

@@ -789,3 +789,12 @@ doesnotexist:-o-prefocus, .strengthify-wrapper {
     opacity: 1;
   }
 }
+
+#sendtestmail_msg {
+	&.error {
+		display: inline-block;
+		margin-top: 5px;
+		border-radius: var(--border-radius);
+		padding: 5px 10px;
+	}
+}

apps/settings/css/settings.css.map

@@ -19,6 +19,8 @@
 use OCP\IURLGenerator;
 use OCP\IUserSession;
 use OCP\Mail\IMailer;
+use Psr\Log\LoggerInterface;
+
 
 class MailSettingsController extends Controller {
 
@@ -39,6 +41,7 @@ public function __construct(
 		private IUserSession $userSession,
 		private IURLGenerator $urlGenerator,
 		private IMailer $mailer,
+		private LoggerInterface $logger,
 	) {
 		parent::__construct($appName, $request);
 	}
@@ -144,6 +147,7 @@ public function sendTestMail() {
 				$this->config->setAppValue('core', 'emailTestSuccessful', '1');
 				return new DataResponse();
 			} catch (\Exception $e) {
+				$this->logger->error('Nextcloud Mail Test Error: ' . $e->getMessage(), ['exception' => $e]);
 				$this->config->setAppValue('core', 'emailTestSuccessful', '0');
 				return new DataResponse($this->l10n->t('A problem occurred while sending the email. Please revise your settings. (Error: %s)', [$e->getMessage()]), Http::STATUS_BAD_REQUEST);
 			}

apps/settings/css/settings.scss

@@ -89,7 +89,7 @@ window.addEventListener('DOMContentLoaded', () => {
 			.then(() => {
 				OC.msg.finishedSuccess('#sendtestmail_msg', t('settings', 'Email sent'))
 			}).catch((error) => {
-				OC.msg.finishedError('#sendtestmail_msg', error)
+				OC.msg.finishedError('#sendtestmail_msg', error.response.data)
 			})
 	})
 })