fix: restore files_accesscontrol functionality within getNodeForPath

This commit adds a workaround to restore the functionality of apps that
rely on descending the file-tree to check for access permissions, like
files_accesscontrol. The navigation is done navigating the tree upwards,
from the target node, to the root node.

Signed-off-by: Salvatore Martire <[email protected]>

Author: salmart-dev

apps/dav/lib/Connector/Sabre/Directory.php

@@ -499,6 +499,7 @@ public function getNode(): Folder {
 
 	public function getNodeForPath($path) {
 		$nodeIsRoot = $this->path === '/';
+		$path = ltrim($path, '/');
 		$fullPath = $nodeIsRoot ? $this->path . $path : $this->path . '/' . $path;
 
 		try {
@@ -518,6 +519,14 @@ public function getNodeForPath($path) {
 				. ' could not be located');
 		}
 
+		if (!$info->isReadable()) {
+			if (Server::get(IAppManager::class)->isEnabledForAnyone('files_accesscontrol')) {
+				throw new Forbidden('No read permissions. This might be caused by files_accesscontrol, check your configured rules');
+			}
+
+			throw new Forbidden('No read permissions');
+		}
+
 		if ($info->getMimeType() === FileInfo::MIMETYPE_FOLDER) {
 			$node = new \OCA\DAV\Connector\Sabre\Directory($this->fileView, $info, $this->tree, $this->shareManager);
 		} else {
@@ -529,6 +538,12 @@ public function getNodeForPath($path) {
 			$node = new File($this->fileView, $info, $this->shareManager);
 		}
 		$this->tree?->cacheNode($node);
+
+		if ($destinationDir !== '') {
+			// recurse upwards until the root (for backwards²-compatibility)
+			$this->getNodeForPath($destinationDir);
+		}
+
 		return $node;
 	}
 }