feat: run rector with new rules

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Author: CarlSchwan

apps/dav/appinfo/v1/publicwebdav.php

@@ -34,6 +34,7 @@
 use OCP\L10N\IFactory as IL10nFactory;
 use OCP\Security\Bruteforce\IThrottler;
 use OCP\Server;
+use OCP\Share\IShare;
 use Psr\Log\LoggerInterface;
 
 // load needed apps
@@ -132,7 +133,7 @@ function (\Sabre\DAV\Server $server) use (
 		Filesystem::logWarningWhenAddingStorageWrapper($previousLog);
 
 		$rootFolder = Server::get(IRootFolder::class);
-		$userId = $share->getShareType() === \OCP\Share\IShare::TYPE_REMOTE
+		$userId = $share->getShareType() === IShare::TYPE_REMOTE
 			? $share->getShareOwner()
 			: $share->getSharedBy();
 		$userFolder = $rootFolder->getUserFolder($userId);

apps/dav/lib/CalDAV/CalDavBackend.php

@@ -2166,7 +2166,7 @@ public function calendarSearch($principalUri, array $filters, $limit = null, $of
 			$result = [];
 			while ($row = $stmt->fetchAssociative()) {
 				$path = $uriMapper[$row['calendarid']] . '/' . $row['uri'];
-				if (!in_array($path, $result)) {
+				if (!in_array($path, $result, true)) {
 					$result[] = $path;
 				}
 			}

apps/dav/lib/CalDAV/EventReader.php

@@ -182,7 +182,7 @@ public function __construct(VCalendar|VEvent|array|string $input, ?string $uid =
 		// evaluate if start date is floating
 		// set duration to 24 hours and calculate the end date
 		// according to the rfc any event without a end date or duration is a complete day
-		elseif ($this->baseEventStartDateFloating == true) {
+		elseif ($this->baseEventStartDateFloating === true) {
 			$this->baseEventDuration = 86400;
 			$this->baseEventEndDate = DateTimeImmutable::createFromInterface($this->baseEventStartDate)
 				->setTimestamp($this->baseEventStartDate->getTimestamp() + $this->baseEventDuration);

apps/dav/lib/CalDAV/Reminder/NotificationProvider/EmailProvider.php

@@ -247,7 +247,7 @@ private function getAllEMailAddressesFromEvent(VEvent $vevent):array {
 				}
 
 				$cuType = $this->getCUTypeOfAttendee($attendee);
-				if (\in_array($cuType, ['RESOURCE', 'ROOM', 'UNKNOWN'])) {
+				if (\in_array($cuType, ['RESOURCE', 'ROOM', 'UNKNOWN'], true)) {
 					// Don't send emails to things
 					continue;
 				}

apps/dav/lib/Connector/Sabre/CachingTree.php

@@ -31,7 +31,7 @@ public function markDirty($path) {
 		$path = trim($path, '/');
 		foreach ($this->cache as $nodePath => $node) {
 			$nodePath = (string)$nodePath;
-			if ($path === '' || $nodePath == $path || str_starts_with($nodePath, $path . '/')) {
+			if ($path === '' || $nodePath === $path || str_starts_with($nodePath, $path . '/')) {
 				unset($this->cache[$nodePath]);
 			}
 		}

apps/dav/lib/DAV/CustomPropertiesBackend.php

@@ -276,11 +276,11 @@ public function propFind($path, PropFind $propFind): void {
 	}
 
 	private function isPropertyAllowed(string $property): bool {
-		if (in_array($property, self::IGNORED_PROPERTIES)) {
+		if (in_array($property, self::IGNORED_PROPERTIES, true)) {
 			return false;
 		}
 		if (str_starts_with($property, '{http://owncloud.org/ns}') || str_starts_with($property, '{http://nextcloud.org/ns}')) {
-			return in_array($property, self::ALLOWED_NC_PROPERTIES);
+			return in_array($property, self::ALLOWED_NC_PROPERTIES, true);
 		}
 		return true;
 	}
@@ -651,7 +651,7 @@ private function encodeValueForDatabase(string $path, string $name, mixed $value
 					"Property \"$name\" has an invalid value of type " . gettype($value),
 				);
 			} else {
-				if (!in_array($value::class, self::ALLOWED_SERIALIZED_CLASSES)) {
+				if (!in_array($value::class, self::ALLOWED_SERIALIZED_CLASSES, true)) {
 					throw new DavException(
 						"Property \"$name\" has an invalid value of class " . $value::class,
 					);

apps/dav/lib/DAV/Sharing/Backend.php

@@ -224,7 +224,7 @@ public function applyShareAcl(array $shares, array $acl): array {
 					'principal' => $share['{' . \OCA\DAV\DAV\Sharing\Plugin::NS_OWNCLOUD . '}principal'],
 					'protected' => true,
 				];
-			} elseif (in_array($this->service->getResourceType(), ['calendar','addressbook'])) {
+			} elseif (in_array($this->service->getResourceType(), ['calendar','addressbook'], true)) {
 				// Allow changing the properties of read only calendars,
 				// so users can change the visibility.
 				$acl[] = [

apps/dav/lib/SystemTag/SystemTagsInUseCollection.php

@@ -32,7 +32,7 @@ public function __construct(
 		protected string $mediaType = '',
 	) {
 		$this->name = 'systemtags-assigned';
-		if ($this->mediaType != '') {
+		if ($this->mediaType !== '') {
 			$this->name .= '/' . $this->mediaType;
 		}
 	}

apps/encryption/lib/Command/CleanOrphanedKeys.php

@@ -94,7 +94,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 		foreach ($orphanedKeys as $keyPath) {
 			$output->writeln('Orphaned key found: ' . $keyPath);
 		}
-		if (count($orphanedKeys) == 0) {
+		if (count($orphanedKeys) === 0) {
 			return self::SUCCESS;
 		}
 		$question = new ConfirmationQuestion('Do you want to delete all orphaned keys? (y/n) ', false);
@@ -199,7 +199,7 @@ private function deleteSpecific(InputInterface $input, OutputInterface $output,
 				return $k !== trim($path);
 			});
 		}
-		if (count($orphanedKeys) == 0) {
+		if (count($orphanedKeys) === 0) {
 			return;
 		}
 		$output->writeln('Remaining orphaned keys: ');

apps/encryption/lib/Command/FixKeyLocation.php

@@ -323,7 +323,7 @@ private function findKeysByFileName(string $basePath, string $name) {
 				throw new \Exception('Invalid base path ' . $basePath);
 			}
 			while ($child = readdir($dh)) {
-				if ($child != '..' && $child != '.') {
+				if ($child !== '..' && $child !== '.') {
 					$childPath = $basePath . '/' . $child;
 
 					// recurse if the child is not a key folder