fixup: avoid too many queries when recursing upwards

Signed-off-by: Salvatore Martire <[email protected]>

Author: salmart-dev

apps/dav/lib/Connector/Sabre/Directory.php

@@ -21,6 +21,7 @@
 use OCP\Files\Folder;
 use OCP\Files\ForbiddenException;
 use OCP\Files\InvalidPathException;
+use OCP\Files\IRootFolder;
 use OCP\Files\Mount\IMountManager;
 use OCP\Files\NotFoundException;
 use OCP\Files\NotPermittedException;
@@ -556,15 +557,14 @@ public function getNodeForPath($path): INode {
 
 		// recurse upwards until the root (for backwards-compatibility)
 		if ($destinationDir !== '') {
-			$scanNode = $node->getNode()->getParent();
-			$scanPath = basename($destinationDir);
-			while ($parent = $scanNode->getParent()) {
-				$parent->get($scanPath);
-				$scanPath = $parent->getName();
-				if ($scanPath === '') {
-					break;
+			$scanPath = $destinationPath;
+			while (($scanPath = dirname($scanPath)) !== '/') {
+				$info = $this->fileView->getFileInfo($scanPath, false);
+				$directory = new Directory($this->fileView, $info, $this->tree, $this->shareManager);
+				$readable = $directory->getNode()->isReadable();
+				if (!$readable) {
+					throw new Forbidden('No read permissions. This might be caused by files_accesscontrol, check your configured rules');
 				}
-				$scanNode = $parent;
 			}
 		}