fix(team-manager): team is already teamid

Signed-off-by: Maxence Lange <[email protected]>

Author: ArtificialOwl

core/Controller/TeamsApiController.php

@@ -66,8 +66,8 @@ public function resolveOne(string $teamId): DataResponse {
 	public function listTeams(string $providerId, string $resourceId): DataResponse {
 		/** @psalm-suppress PossiblyNullArgument The route is limited to logged-in users */
 		$teams = $this->teamManager->getTeamsForResource($providerId, $resourceId, $this->userId);
-		$sharesPerTeams = $this->teamManager->getSharedWithList(array_map(fn (Team $team): string => $team->getId(), $teams), $this->userId);
-		$listTeams = array_values(array_map(function (Team $team) use ($sharesPerTeams) {
+		$sharesPerTeams = $this->teamManager->getSharedWithList(array_map(static fn (Team $team): string => $team->getId(), $teams), $this->userId);
+		$listTeams = array_values(array_map(static function (Team $team) use ($sharesPerTeams) {
 			$response = $team->jsonSerialize();
 			$response['resources'] = array_map(static fn (TeamResource $resource) => $resource->jsonSerialize(), $sharesPerTeams[$team->getId()] ?? []);
 			return $response;

lib/private/Teams/TeamManager.php

@@ -95,7 +95,7 @@ public function getSharedWithList(array $teams, string $userId): array {
 				$resources[] = $provider->getSharedWithList($teams, $userId);
 			} else {
 				foreach ($teams as $team) {
-					$resources[] = [$team->getId() => $provider->getSharedWith($team->getId())];
+					$resources[] = [$team => $provider->getSharedWith($team)];
 				}
 			}
 		}

lib/public/Teams/ITeamManager.php

@@ -42,7 +42,7 @@ public function getSharedWith(string $teamId, string $userId): array;
 	public function getTeamsForResource(string $providerId, string $resourceId, string $userId): array;
 
 	/**
-	 * @param list<Team> $teams
+	 * @param string[] $teams
 	 * @return array<string, list<TeamResource>>
 	 *
 	 * @since 33.0.0