fix(tests): Apply PHP-CS-Fixer code style corrections

Apply code style fixes to S3 encryption tests:
- Change double quotes to single quotes in assertion messages
- Fix array indentation
- Remove unused imports

Signed-off-by: Claude Sonnet 4.5 <[email protected]>
Signed-off-by: Stephen Cuppett <[email protected]>

Author: cuppett

tests/lib/Files/ObjectStore/S3EncryptionMigrationTest.php

@@ -10,11 +10,8 @@
 namespace Test\Files\ObjectStore;
 
 use OC\Files\ObjectStore\S3;
-use OCA\Encryption\Crypto\EncryptAll;
 use OCP\IConfig;
 use OCP\Server;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Output\BufferedOutput;
 use Test\Traits\EncryptionTrait;
 use Test\Traits\MountProviderTrait;
 use Test\Traits\UserTrait;
@@ -184,12 +181,12 @@ public function testIsEncryptedFlag(): void {
 
 		// Verify encrypted flag is set via node
 		$this->assertTrue($node->isEncrypted(),
-			"File should be marked as encrypted in database after write");
+			'File should be marked as encrypted in database after write');
 
 		// Verify content is accessible
 		$readContent = $this->view->file_get_contents($testFile);
 		$this->assertEquals($content, $readContent,
-			"Content should be readable after encryption");
+			'Content should be readable after encryption');
 
 		// Clean up
 		$this->view->unlink($testFile);
@@ -210,12 +207,12 @@ public function testDetectUnencryptedFilesQuery(): void {
 			->from('filecache')
 			->where($query->expr()->eq('encrypted', $query->createNamedParameter(0)))
 			->andWhere($query->expr()->neq('mimetype',
-				$query->createFunction('(SELECT id FROM oc_mimetypes WHERE mimetype = ' .
-					$query->createNamedParameter('httpd/unix-directory') . ')')
+				$query->createFunction('(SELECT id FROM oc_mimetypes WHERE mimetype = '
+					. $query->createNamedParameter('httpd/unix-directory') . ')')
 			))
 			->andWhere($query->expr()->like('storage',
-				$query->createFunction('(SELECT numeric_id FROM oc_storages WHERE id LIKE ' .
-					$query->createNamedParameter('object::%') . ')')
+				$query->createFunction('(SELECT numeric_id FROM oc_storages WHERE id LIKE '
+					. $query->createNamedParameter('object::%') . ')')
 			));
 
 		$result = $query->executeQuery();
@@ -225,7 +222,7 @@ public function testDetectUnencryptedFilesQuery(): void {
 		// After our encrypted file, this should be 0 or low
 		// (may have system files that aren't encrypted)
 		$this->assertIsNumeric($unencryptedCount,
-			"Should be able to query unencrypted file count");
+			'Should be able to query unencrypted file count');
 
 		// Clean up
 		$this->view->unlink('migration-test-encrypted.txt');
@@ -261,11 +258,11 @@ public function testSizeConsistencyAfterEncryption(): void {
 
 		// Assertions
 		$this->assertEquals($size, $dbSize,
-			"Database should have unencrypted size");
+			'Database should have unencrypted size');
 		$this->assertEquals($size, $actualSize,
-			"Read content should match original size");
+			'Read content should match original size');
 		$this->assertGreaterThan($size, $s3Size,
-			"S3 should have encrypted size (larger)");
+			'S3 should have encrypted size (larger)');
 
 		// Clean up
 		$this->view->unlink($testFile);

tests/lib/Files/ObjectStore/S3EncryptionTest.php

@@ -11,7 +11,6 @@
 
 use OC\Files\ObjectStore\ObjectStoreStorage;
 use OC\Files\ObjectStore\S3;
-use OCP\Files\IMimeTypeLoader;
 use OCP\IConfig;
 use OCP\Server;
 use Test\Traits\EncryptionTrait;
@@ -140,7 +139,7 @@ protected function tearDown(): void {
 	private function cleanupTestFiles(): void {
 		// Clean up any test files that match our patterns
 		$patterns = ['test-size-*', 'test-roundtrip-*', 'test-integrity-*',
-		             'test-partial-read*', 'test-seek*', 'test-multipart*', 'test.txt'];
+			'test-partial-read*', 'test-seek*', 'test-multipart*', 'test.txt'];
 
 		foreach ($patterns as $pattern) {
 			try {
@@ -206,7 +205,7 @@ public function testSizeConsistencyAcrossSources(int $originalSize): void {
 		$bytesWritten = $this->view->file_put_contents($testFile, $data);
 
 		$this->assertEquals($originalSize, $bytesWritten,
-			"file_put_contents should return original size written");
+			'file_put_contents should return original size written');
 
 		// 2. Get database size (from filecache via userFolder)
 		$node = $this->userFolder->get($testFile);
@@ -235,15 +234,15 @@ public function testSizeConsistencyAcrossSources(int $originalSize): void {
 		if ($originalSize === 0) {
 			// Zero-byte files still get encryption header in S3
 			$this->assertGreaterThan(0, $s3Size,
-				"S3 should have encryption header even for empty files");
+				'S3 should have encryption header even for empty files');
 		} else {
 			$this->assertGreaterThan($originalSize, $s3Size,
 				"S3 size should be larger than original due to encryption overhead (original: $originalSize, s3: $s3Size)");
 		}
 
 		// Verify content integrity - critical!
 		$this->assertEquals($data, $content,
-			"Content should be identical after encrypt/decrypt cycle - corruption detected!");
+			'Content should be identical after encrypt/decrypt cycle - corruption detected!');
 
 		// Validate encryption overhead is reasonable
 		// Binary signed format: Header (8192 bytes) + data blocks
@@ -254,9 +253,9 @@ public function testSizeConsistencyAcrossSources(int $originalSize): void {
 		if ($originalSize === 0) {
 			// Zero-byte files still get encryption header
 			$this->assertGreaterThan(0, $s3Size,
-				"Even empty files should have encryption header in S3");
+				'Even empty files should have encryption header in S3');
 			$this->assertLessThanOrEqual(8192, $s3Size,
-				"Empty file should only have header block");
+				'Empty file should only have header block');
 		} else {
 			$overheadPercent = (($s3Size - $originalSize) / $originalSize) * 100;
 
@@ -300,7 +299,7 @@ public function testEncryptedFileRoundTrip(int $size): void {
 		$this->assertEquals($size, strlen($readData));
 
 		// Verify content
-		$this->assertEquals($data, $readData, "Content mismatch after round trip");
+		$this->assertEquals($data, $readData, 'Content mismatch after round trip');
 
 		// Clean up
 		$this->view->unlink($testFile);
@@ -331,8 +330,8 @@ public function testEncryptedFileIntegrity(int $size): void {
 		fclose($handle);
 
 		// Verify
-		$this->assertEquals($size, strlen($readData), "Size mismatch in streaming read");
-		$this->assertEquals($data, $readData, "Content mismatch in streaming read");
+		$this->assertEquals($size, strlen($readData), 'Size mismatch in streaming read');
+		$this->assertEquals($data, $readData, 'Content mismatch in streaming read');
 
 		// Clean up
 		$this->view->unlink($testFile);
@@ -430,12 +429,12 @@ public function testEncryptedMultipartUpload(): void {
 		$node = $this->userFolder->get($testFile);
 		$dbSize = $node->getSize();
 		$this->assertEquals($size, $dbSize,
-			"Database should have unencrypted size even for multipart upload");
+			'Database should have unencrypted size even for multipart upload');
 
 		// Verify content
 		$readData = $this->view->file_get_contents($testFile);
 		$this->assertEquals($data, $readData,
-			"Content mismatch for multipart encrypted upload");
+			'Content mismatch for multipart encrypted upload');
 
 		// Clean up
 		$this->view->unlink($testFile);
@@ -486,7 +485,7 @@ public function testEncryptedFileMimeType(): void {
 
 		// Should detect as text/plain
 		$this->assertEquals('text/plain', $mimeType,
-			"MIME type detection should work on encrypted files");
+			'MIME type detection should work on encrypted files');
 
 		// Clean up
 		$this->view->unlink($testFile);