fix(sharing): move lookup label flag to core app config

Signed-off-by: nicolas.varlot@ac-versailles.fr

Signed-off-by: Nicolas Varlot <nicolas.varlot@ac-versailles.fr>

Author: n-iv

lib/private/Collaboration/Collaborators/LookupPlugin.php

@@ -38,11 +38,11 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b
 		$isGlobalScaleEnabled = $this->config->getSystemValueBool('gs.enabled', false);
 		$isLookupServerEnabled = $this->config->getAppValue('files_sharing', 'lookupServerEnabled', 'no') === 'yes';
 		$hasInternetConnection = $this->config->getSystemValueBool('has_internet_connection', true);
-		// System config flag: shareapi_lookup_label_show_email
+		// App config flag (core app config): shareapi_lookup_label_show_email
 		// Controls whether email addresses from federated lookup results are shown in share dialog labels.
-		// Defaults to false to avoid exposing email addresses unnecessarily. Enabling this may reveal
+		// Defaults to 'no' to avoid exposing email addresses unnecessarily. Enabling this may reveal
 		// users' email addresses to people using the share dialog and should therefore be considered carefully.
-		$showEmailInLabel = $this->config->getSystemValueBool('shareapi_lookup_label_show_email', false);
+		$showEmailInLabel = $this->config->getAppValue('core', 'shareapi_lookup_label_show_email', 'no') === 'yes';
 
 		// If case of Global Scale we always search the lookup server
 		// TODO: Reconsider using the lookup server for non-global scale
@@ -86,10 +86,12 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b
 				$email = $lookup['email']['value'] ?? '';
 
 				if ($showEmailInLabel && $email !== '') {
-					$label = empty($name) ? $email : $name . ' (' . $email . ')';
+					$id = $email;
 				} else {
-					$label = empty($name) ? $lookup['federationId'] : $name . ' (' . $lookup['federationId'] . ')';
+					$id = $lookup['federationId'];
 				}
+				$label = $name === '' ? $id : $name . ' (' . $id . ')';
+
 				$result[] = [
 					'label' => $label,
 					'value' => [