refactor: Rebase master on top of node changes

Signed-off-by: Carl Schwan <[email protected]>

Author: CarlSchwan

apps/dav/lib/Connector/Sabre/File.php

@@ -543,9 +543,6 @@ public function getDirectDownload(): array|false {
 		}
 		$node = $this->getNode();
 		$storage = $node->getStorage();
-		if (!$storage) {
-			return false;
-		}
 
 		if (!($node->getPermissions() & Constants::PERMISSION_READ)) {
 			return false;

build/psalm-baseline.xml

@@ -626,7 +626,6 @@
       <code><![CDATA[resolvePath]]></code>
       <code><![CDATA[resolvePath]]></code>
       <code><![CDATA[resolvePath]]></code>
-      <code><![CDATA[resolvePath]]></code>
       <code><![CDATA[touch]]></code>
       <code><![CDATA[unlink]]></code>
     </InternalMethod>

lib/private/Share20/Manager.php

@@ -1601,7 +1601,7 @@ public function userDeletedFromGroup($uid, $gid) {
 	}
 
 	#[\Override]
-	public function getAccessList(\OCP\Files\Node $path, $recursive = true, $currentAccess = false) {
+	public function getAccessList(\OCP\Files\Node $path, $recursive = true, $currentAccess = false): array {
 		$owner = $path->getOwner();
 
 		if ($owner === null) {

lib/public/Share/IManager.php

@@ -275,10 +275,10 @@ public function userDeletedFromGroup($uid, $gid);
 	 * @param bool $currentAccess Should the user have currently access to the file
 	 * @return ($currentAccess is true
 	 * 		? array{
-	 *     		users?: array<string, array{node_id: int, node_path: string}>,
-	 *     		remote?: array<string, array{node_id: int, node_path: string}>,
+	 *     		users?: array<string, array{node_id: ?int, node_path: string}>,
+	 *     		remote?: array<string, array{node_id: ?int, node_path: string}>,
 	 *     		public?: bool,
-	 *     		mail?: array<string, array{node_id: int, node_path: string}>
+	 *     		mail?: array<string, array{node_id: ?int, node_path: string}>
 	 *     	}
 	 *      : array{users?: list<string>, remote?: bool, public?: bool, mail?: list<string>})
 	 * @since 12.0.0