test(settings): add tests for developer documentation link generation

Signed-off-by: Arsalan Ul Haq Sohni <[email protected]>

Author: Arsalanulhaq

apps/settings/tests/Controller/AppSettingsControllerTest.php

@@ -169,9 +169,21 @@ public function testViewApps(): void {
 			->method('setActiveEntry')
 			->with('core_apps');
 
+		// Test that developer docs link is generated correctly
+		$this->urlGenerator
+			->expects($this->once())
+			->method('linkToDocs')
+			->with('developer-manual')
+			->willReturn('https://docs.nextcloud.com/server/latest/developer_manual/');
+
 		$this->initialState
 			->expects($this->exactly(4))
-			->method('provideInitialState');
+			->method('provideInitialState')
+			->willReturnCallback(function ($key, $value) {
+				if ($key === 'appstoreDeveloperDocs') {
+					$this->assertEquals('https://docs.nextcloud.com/server/latest/developer_manual/', $value);
+				}
+			});
 
 		$policy = new ContentSecurityPolicy();
 		$policy->addAllowedImageDomain('https://usercontent.apps.nextcloud.com');
@@ -202,9 +214,21 @@ public function testViewAppsAppstoreNotEnabled(): void {
 			->method('setActiveEntry')
 			->with('core_apps');
 
+		// Test that developer docs link is still generated even when appstore is disabled
+		$this->urlGenerator
+			->expects($this->once())
+			->method('linkToDocs')
+			->with('developer-manual')
+			->willReturn('https://docs.nextcloud.com/server/latest/developer_manual/');
+
 		$this->initialState
 			->expects($this->exactly(4))
-			->method('provideInitialState');
+			->method('provideInitialState')
+			->willReturnCallback(function ($key, $value) {
+				if ($key === 'appstoreDeveloperDocs') {
+					$this->assertEquals('https://docs.nextcloud.com/server/latest/developer_manual/', $value);
+				}
+			});
 
 		$policy = new ContentSecurityPolicy();
 		$policy->addAllowedImageDomain('https://usercontent.apps.nextcloud.com');
@@ -219,4 +243,93 @@ public function testViewAppsAppstoreNotEnabled(): void {
 
 		$this->assertEquals($expected, $this->appSettingsController->viewApps());
 	}
+
+	public function testDeveloperDocumentationLinkIsProvided(): void {
+		$this->installer->expects($this->any())
+			->method('isUpdateAvailable')
+			->willReturn(false);
+		$this->bundleFetcher->expects($this->once())->method('getBundles')->willReturn([]);
+		$this->config
+			->expects($this->once())
+			->method('getSystemValueBool')
+			->with('appstoreenabled', true)
+			->willReturn(true);
+		$this->navigationManager
+			->expects($this->once())
+			->method('setActiveEntry')
+			->with('core_apps');
+
+		$developerDocsUrl = 'https://docs.nextcloud.com/server/latest/developer_manual/';
+
+		// Verify that linkToDocs is called with 'developer-manual'
+		$this->urlGenerator
+			->expects($this->once())
+			->method('linkToDocs')
+			->with('developer-manual')
+			->willReturn($developerDocsUrl);
+
+		// Verify that the developer docs URL is provided to initial state
+		$providedStates = [];
+		$this->initialState
+			->expects($this->exactly(4))
+			->method('provideInitialState')
+			->willReturnCallback(function ($key, $value) use (&$providedStates) {
+				$providedStates[$key] = $value;
+			});
+
+		$this->appSettingsController->viewApps();
+
+		// Assert that the developer docs state was provided with the correct URL
+		$this->assertArrayHasKey('appstoreDeveloperDocs', $providedStates);
+		$this->assertEquals($developerDocsUrl, $providedStates['appstoreDeveloperDocs']);
+	}
+
+	/**
+	 * @dataProvider developerDocsUrlProvider
+	 */
+	public function testDeveloperDocumentationLinkWithDifferentUrls(string $expectedUrl): void {
+		$this->installer->expects($this->any())
+			->method('isUpdateAvailable')
+			->willReturn(false);
+		$this->bundleFetcher->expects($this->once())->method('getBundles')->willReturn([]);
+		$this->config
+			->expects($this->once())
+			->method('getSystemValueBool')
+			->with('appstoreenabled', true)
+			->willReturn(true);
+		$this->navigationManager
+			->expects($this->once())
+			->method('setActiveEntry')
+			->with('core_apps');
+
+		// Test with different potential URL formats
+		$this->urlGenerator
+			->expects($this->once())
+			->method('linkToDocs')
+			->with('developer-manual')
+			->willReturn($expectedUrl);
+
+		$providedStates = [];
+		$this->initialState
+			->expects($this->exactly(4))
+			->method('provideInitialState')
+			->willReturnCallback(function ($key, $value) use (&$providedStates) {
+				$providedStates[$key] = $value;
+			});
+
+		$this->appSettingsController->viewApps();
+
+		$this->assertArrayHasKey('appstoreDeveloperDocs', $providedStates);
+		$this->assertEquals($expectedUrl, $providedStates['appstoreDeveloperDocs']);
+	}
+
+	public function developerDocsUrlProvider(): array {
+		return [
+			'standard URL' => ['https://docs.nextcloud.com/server/latest/developer_manual/'],
+			'versioned URL' => ['https://docs.nextcloud.com/server/28/developer_manual/'],
+			'custom domain' => ['https://custom-docs.example.com/developer/'],
+			'relative URL' => ['/docs/developer-manual'],
+			'with anchor' => ['https://docs.nextcloud.com/server/latest/developer_manual/#getting-started'],
+		];
+	}
 }