Merge pull request #63783 from nextcloud/dependabot/composer/vendor-bin/rector/stable35/rector/rector-2.6.3

[stable35] build(deps-dev): bump rector/rector from 2.6.1 to 2.6.3 in /vendor-bin/rector

Author: susnux

build/rector-shared.php

@@ -68,11 +68,11 @@ public function shouldSkip(File $file, FullyQualifiedObjectType $fullyQualifiedO
 		'rename_property' => true,
 	])
 	->withSets([
-		NextcloudSets::NEXTCLOUD_27,
-		PHPUnitSetList::PHPUNIT_100,
+		NextcloudSets::NEXTCLOUD_32,
+		PHPUnitSetList::COMPOSER_BASED,
 	]);
 
-$config->registerService(NextcloudNamespaceSkipVoter::class, tag:ClassNameImportSkipVoterInterface::class);
+$config->registerService(NextcloudNamespaceSkipVoter::class);
 
 /* Ignore all files ignored by git */
 $ignoredEntries = shell_exec('git status --porcelain --ignored ' . escapeshellarg($nextcloudDir));

core/css/fixes.css

@@ -1,4 +1,4 @@
 /*!
  * SPDX-FileCopyrightText: 2017 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later
- */::-moz-focus-inner{border:0}/*# sourceMappingURL=fixes.css.map */
+ */::-moz-focus-inner{border:0}.nc-select__dropdown.vs__dropdown-menu{--vs-dropdown-z-index: 9999}/*# sourceMappingURL=fixes.css.map */

core/css/fixes.css.map

@@ -9,3 +9,15 @@
 	border: 0;
 }
 
+/* ---- LIBRARY FIXES ---- */
+
+/**
+ * TODO: Hotfix for https://github.com/nextcloud-libraries/nextcloud-vue/issues/8783
+ *
+ * NcSelect appends its dropdown to the body, but `--vs-dropdown-z-index` is only
+ * set on the select itself, so the dropdown falls back to the vue-select default
+ * of 1000 and ends up behind modals (z-index 9998 and above).
+ */
+.nc-select__dropdown.vs__dropdown-menu {
+	--vs-dropdown-z-index: 9999;
+}

core/css/fixes.scss

@@ -35,9 +35,7 @@ public function __construct(
 	 * @return EntityInfo<T>
 	 */
 	public function getEntityInfo(string $entityClass): EntityInfo {
-		if (!isset($this->entitiesInfo[$entityClass])) {
-			$this->entitiesInfo[$entityClass] = new EntityInfo($entityClass);
-		}
+		$this->entitiesInfo[$entityClass] ??= new EntityInfo($entityClass);
 
 		/** @var EntityInfo<T> $entityInfo */
 		$entityInfo = $this->entitiesInfo[$entityClass];

core/css/server.css

@@ -79,12 +79,10 @@ public function format(ISharingRegistry $registry, IFactory $l10nFactory, IURLGe
 		}
 
 		$icon = $recipientType->getRecipientIcon($this->value);
-		if ($icon === null) {
-			$icon = new ShareIconURL(
-				$urlGenerator->linkToRouteAbsolute('core.GuestAvatar.getAvatar', ['guestName' => $displayName, 'size' => 64]),
-				$urlGenerator->linkToRouteAbsolute('core.GuestAvatar.getAvatar', ['guestName' => $displayName, 'size' => 64, 'darkTheme' => true]),
-			);
-		}
+		$icon ??= new ShareIconURL(
+			$urlGenerator->linkToRouteAbsolute('core.GuestAvatar.getAvatar', ['guestName' => $displayName, 'size' => 64]),
+			$urlGenerator->linkToRouteAbsolute('core.GuestAvatar.getAvatar', ['guestName' => $displayName, 'size' => 64, 'darkTheme' => true]),
+		);
 
 		return [
 			'class' => $this->class,

core/css/server.css.map

@@ -14,7 +14,7 @@ test.describe('Files: Delete', () => {
 		const row = filesListPage.getRowForFile('file.txt')
 		await expect(row).toBeVisible()
 		// Preview must finish loading before delete — a loading preview can lock the file
-		await expect(row.locator('.files-list__row-icon-preview--loaded')).toBeVisible()
+		await filesListPage.waitForPreviewLoaded('file.txt')
 
 		const deleteResponse = page.waitForResponse(
 			(r) => r.url().includes('/remote.php/dav/files/') && r.request().method() === 'DELETE',

lib/private/AppFramework/ORM/EntityManager.php

@@ -14,12 +14,15 @@ const SHARE_NAME = 'shared'
  * by a guest.
  */
 test.describe('files_sharing: Public share - copy, move and rename files', () => {
-	test.beforeEach(async ({ user, ownerRequest, publicShare }) => {
+	test.beforeEach(async ({ user, ownerRequest, publicShare, filesListPage }) => {
 		await seedSharedFolder(ownerRequest, user, SHARE_NAME)
 		const share = await createLinkShare(ownerRequest, `/${SHARE_NAME}`, {
 			permissions: BUNDLED_PERMISSIONS.UPLOAD_AND_UPDATE,
 		})
 		await publicShare.open(share.url)
+		// Every test moves, copies or renames foo.txt, so its preview has to be
+		// loaded first — a preview being generated locks the file on the server.
+		await filesListPage.waitForPreviewLoaded('foo.txt')
 	})
 
 	test('can copy a file to another folder', async ({ page, filesListPage, copyMoveDialog }) => {