fixup: hide share and mount information from permission string

Signed-off-by: Salvatore Martire <[email protected]>

Author: salmart-dev

apps/dav/lib/Connector/Sabre/AddExtraHeadersPlugin.php

@@ -8,6 +8,7 @@
  */
 namespace OCA\DAV\Connector\Sabre;
 
+use OCA\DAV\Connector\PermissionsTrait;
 use Psr\Log\LoggerInterface;
 use Sabre\DAV\Exception\NotFound;
 use Sabre\DAV\Server;
@@ -20,10 +21,14 @@
  * to display.
  */
 class AddExtraHeadersPlugin extends \Sabre\DAV\ServerPlugin {
+
+	use PermissionsTrait;
+
 	private ?Server $server = null;
 
 	public function __construct(
 		private LoggerInterface $logger,
+		private bool $isPublic = false,
 	) {
 	}
 
@@ -57,9 +62,10 @@ private function afterPut(RequestInterface $request, ResponseInterface $response
 			$response->setHeader('X-NC-OwnerId', $ownerId);
 		}
 
-		$permissions = $node->getDavPermissions();
-		if ($permissions !== null) {
-			$response->setHeader('X-NC-Permissions', $permissions);
-		}
+		$permissions = $this->getPermissionString(
+			$this->isPublic,
+			$node->getDavPermissions()
+		);
+		$response->setHeader('X-NC-Permissions', $permissions);
 	}
 }

apps/dav/lib/Connector/Sabre/ServerFactory.php

@@ -238,7 +238,7 @@ public function createServer(
 				);
 			}
 			$server->addPlugin(new CopyEtagHeaderPlugin());
-			$server->addPlugin(new AddExtraHeadersPlugin($this->logger));
+			$server->addPlugin(new AddExtraHeadersPlugin($this->logger, $isPublicShare));
 
 			// Load dav plugins from apps
 			$event = new SabrePluginEvent($server);

apps/dav/lib/Server.php

@@ -383,7 +383,7 @@ public function __construct(
 						)
 					);
 				}
-				$this->server->addPlugin(new AddExtraHeadersPlugin($logger));
+				$this->server->addPlugin(new AddExtraHeadersPlugin($logger, false));
 				$this->server->addPlugin(new EnablePlugin(
 					\OCP\Server::get(IConfig::class),
 					\OCP\Server::get(BirthdayService::class),

apps/dav/tests/unit/Connector/Sabre/AddExtraHeadersPluginTest.php

@@ -129,7 +129,7 @@ protected function setUp(): void {
 		$this->tree = $this->createMock(Tree::class);
 		$this->server->tree = $this->tree;
 		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->plugin = new AddExtraHeadersPlugin($this->logger);
+		$this->plugin = new AddExtraHeadersPlugin($this->logger, false);
 		$this->request = $this->createMock(RequestInterface::class);
 		$this->response = $this->createMock(ResponseInterface::class);
 	}