feat(theming): allow to disable standalone windows

Co-authored-by: Ferdinand Thiessen <[email protected]>

Signed-off-by: Simon L. <[email protected]>

Signed-off-by: Hamza Mahjoubi <[email protected]>

Author: szaimen

Diff for: apps/theming/lib/Controller/ThemingController.php

@@ -474,7 +474,7 @@ public function getManifest(string $app): JSONResponse {
 						'sizes' => '16x16'
 					]
 				],
-			'display' => 'standalone'
+			'display' => $this->config->getSystemValueBool('theming.standalone_window.enabled', true) ? 'standalone' : 'browser'
 		];
 		$response = new JSONResponse($responseJS);
 		$response->cacheFor(3600);

Diff for: apps/theming/tests/Controller/ThemingControllerTest.php

@@ -705,7 +705,15 @@ public function testGetLoginBackground() {
 		@$this->assertEquals($expected, $this->themingController->getImage('background'));
 	}
 
-	public function testGetManifest() {
+	public static function dataGetManifest(): array {
+		return [
+			[true],
+			[false],
+		];
+	}
+
+	/** @dataProvider dataGetManifest */
+	public function testGetManifest(bool $standalone) {
 		$this->config
 			->expects($this->once())
 			->method('getAppValue')
@@ -729,6 +737,11 @@ public function testGetManifest() {
 				'touchicon',
 				'favicon',
 			);
+		$this->config
+			->expects($this->once())
+			->method('getSystemValueBool')
+			->with('theming.standalone_window.enabled', true)
+			->willReturn($standalone);
 		$response = new Http\JSONResponse([
 			'name' => 'Nextcloud',
 			'start_url' => 'localhost',
@@ -745,7 +758,7 @@ public function testGetManifest() {
 						'sizes' => '16x16'
 					]
 				],
-			'display' => 'standalone',
+			'display' => $standalone ? 'standalone' : 'browser',
 			'short_name' => 'Nextcloud',
 			'theme_color' => null,
 			'background_color' => null,

Diff for: config/config.sample.php

@@ -2079,6 +2079,14 @@
  */
 'enforce_theme' => '',
 
+
+/**
+ * This setting allows to disable the PWA functionality that allows browsers to open web applications in dedicated windows.
+ *
+ * Defaults to ``true``
+ */
+'theming.standalone_window.enabled' => true,
+
 /**
  * The default cipher for encrypting files. Currently supported are:
  *  - AES-256-CTR