perf: cache root cache entries for external storage in MountCacheService

Signed-off-by: Robin Appelman <[email protected]>

Author: icewind1991

apps/files_external/lib/Service/MountCacheService.php

@@ -15,6 +15,7 @@
 use OCA\Files_External\Event\StorageDeletedEvent;
 use OCA\Files_External\Event\StorageUpdatedEvent;
 use OCA\Files_External\Lib\StorageConfig;
+use OCP\Cache\CappedMemoryCache;
 use OCP\EventDispatcher\Event;
 use OCP\EventDispatcher\Event as T;
 use OCP\EventDispatcher\IEventListener;
@@ -35,13 +36,16 @@
  * @template-implements IEventListener<StorageCreatedEvent|StorageDeletedEvent|StorageUpdatedEvent|BeforeGroupDeletedEvent|UserCreatedEvent|UserAddedEvent|UserRemovedEvent|Event>
  */
 class MountCacheService implements IEventListener {
+	private CappedMemoryCache $storageRootCache;
+
 	public function __construct(
 		private readonly IUserMountCache $userMountCache,
 		private readonly ConfigAdapter $configAdapter,
 		private readonly IUserManager $userManager,
 		private readonly IGroupManager $groupManager,
 		private readonly GlobalStoragesService $storagesService,
 	) {
+		$this->storageRootCache = new CappedMemoryCache();
 	}
 
 	public function handle(Event $event): void {
@@ -128,11 +132,16 @@ public function registerUpdatedStorage(StorageConfig $oldStorage, StorageConfig
 	}
 
 	private function getCacheEntryForRoot(IUser $user, StorageConfig $storage): ICacheEntry {
-		// todo: reuse these between users when possible
 		$storage = $this->configAdapter->constructStorageForUser($user, $storage);
+
+		if ($cachedEntry = $this->storageRootCache->get($storage->getId())) {
+			return $cachedEntry;
+		}
+
 		$cache = $storage->getCache();
 		$entry = $cache->get('');
 		if ($entry) {
+			$this->storageRootCache->set($storage->getId(), $entry);
 			return $entry;
 		}
 
@@ -156,7 +165,9 @@ private function getCacheEntryForRoot(IUser $user, StorageConfig $storage): ICac
 		];
 		$data['fileid'] = $cache->insert('', $data);
 
-		return new CacheEntry($data);
+		$entry = new CacheEntry($data);
+		$this->storageRootCache->set($storage->getId(), $entry);
+		return $entry;
 	}
 
 	private function registerForUser(IUser $user, StorageConfig $storage): void {