fix: the core config is not loaded on error pages

Signed-off-by: Ferdinand Thiessen <[email protected]>

Author: susnux

core/src/session-heartbeat.ts

@@ -19,11 +19,12 @@ interface OcJsConfig {
 	session_lifetime: number
 }
 
+// This is always set, exception would be e.g. error pages where this is undefined
 const {
 	auto_logout: autoLogout,
 	session_keepalive: keepSessionAlive,
 	session_lifetime: seesionLifetime,
-} = loadState<OcJsConfig>('core', 'config')
+} = loadState<Partial<OcJsConfig>>('core', 'config', {})
 
 /**
  * Calls the server periodically to ensure that session and CSRF
@@ -145,7 +146,7 @@ function registerAutoLogout() {
 
 	let intervalId = 0
 	const logoutCheck = () => {
-		const timeout = Date.now() - seesionLifetime * 1000
+		const timeout = Date.now() - (seesionLifetime ?? 86400) * 1000
 		if (lastActive < timeout) {
 			clearTimeout(intervalId)
 			logger.info('Inactivity timout reached, logging out')

core/src/tests/OC/session-heartbeat.spec.ts

@@ -35,7 +35,7 @@ describe('Session heartbeat', () => {
 		initSessionHeartBeat()
 
 		// initial state loaded
-		expect(initialState.loadState).toBeCalledWith('core', 'config')
+		expect(initialState.loadState).toBeCalledWith('core', 'config', {})
 
 		// less than half, still nothing
 		await vi.advanceTimersByTimeAsync(100 * 1000)
@@ -64,7 +64,7 @@ describe('Session heartbeat', () => {
 		initSessionHeartBeat()
 
 		// initial state loaded
-		expect(initialState.loadState).toBeCalledWith('core', 'config')
+		expect(initialState.loadState).toBeCalledWith('core', 'config', {})
 
 		// less than half, still nothing
 		await vi.advanceTimersByTimeAsync(100 * 1000)
@@ -85,7 +85,7 @@ describe('Session heartbeat', () => {
 		initSessionHeartBeat()
 
 		// initial state loaded
-		expect(initialState.loadState).toBeCalledWith('core', 'config')
+		expect(initialState.loadState).toBeCalledWith('core', 'config', {})
 
 		// 30 / 55 seconds
 		await vi.advanceTimersByTimeAsync(30 * 1000)
@@ -110,7 +110,7 @@ describe('Session heartbeat', () => {
 		initSessionHeartBeat()
 
 		// initial state loaded
-		expect(initialState.loadState).toBeCalledWith('core', 'config')
+		expect(initialState.loadState).toBeCalledWith('core', 'config', {})
 
 		// 23 hours
 		await vi.advanceTimersByTimeAsync(23 * 60 * 60 * 1000)