fix(profile): Directly migrate to OCP constants

Signed-off-by: Joas Schilling <[email protected]>

Author: nickvergessen

core/Db/ProfileConfig.php

@@ -26,7 +26,6 @@
 
 namespace OC\Core\Db;
 
-use OCP\Profile\IProfileManager;
 use function Safe\json_decode;
 use function Safe\json_encode;
 use \JsonSerializable;
@@ -40,46 +39,6 @@
  * @method void setConfig(string $config)
  */
 class ProfileConfig extends Entity implements JsonSerializable {
-	/**
-	 * Visible to users, guests, and public access
-	 *
-	 * @since 23.0.0
-	 * @deprecated 28.0.0 Use {@see IProfileManager::VISIBILITY_SHOW} instead
-	 */
-	public const VISIBILITY_SHOW = IProfileManager::VISIBILITY_SHOW;
-
-	/**
-	 * Visible to users and guests
-	 *
-	 * @since 23.0.0
-	 * @deprecated 28.0.0 Use {@see IProfileManager::VISIBILITY_SHOW_USERS_ONLY} instead
-	 */
-	public const VISIBILITY_SHOW_USERS_ONLY = IProfileManager::VISIBILITY_SHOW_USERS_ONLY;
-
-	/**
-	 * Visible to nobody
-	 *
-	 * @since 23.0.0
-	 * @deprecated 28.0.0 Use {@see IProfileManager::VISIBILITY_HIDE} instead
-	 */
-	public const VISIBILITY_HIDE = IProfileManager::VISIBILITY_HIDE;
-
-	/**
-	 * Default account property visibility
-	 *
-	 * @since 23.0.0
-	 * @deprecated 28.0.0 Use {@see IProfileManager::DEFAULT_PROPERTY_VISIBILITY} instead
-	 */
-	public const DEFAULT_PROPERTY_VISIBILITY = IProfileManager::DEFAULT_PROPERTY_VISIBILITY;
-
-	/**
-	 * Default visibility
-	 *
-	 * @since 23.0.0
-	 * @deprecated 28.0.0 Use {@see IProfileManager::DEFAULT_VISIBILITY} instead
-	 */
-	public const DEFAULT_VISIBILITY = IProfileManager::DEFAULT_VISIBILITY;
-
 	/** @var string */
 	protected $userId;
 

lib/private/Profile/ProfileManager.php

@@ -205,7 +205,7 @@ public function isProfileFieldVisible(string $profileField, IUser $targetUser, ?
 		$visibility = $this->getProfileConfig($targetUser, $visitingUser)[$profileField]['visibility'];
 		// Handle profile visibility and account property scope
 
-		if ($visibility === ProfileConfig::VISIBILITY_SHOW_USERS_ONLY) {
+		if ($visibility === self::VISIBILITY_SHOW_USERS_ONLY) {
 			if (empty($scope)) {
 				return $visitingUser !== null;
 			}
@@ -219,7 +219,7 @@ public function isProfileFieldVisible(string $profileField, IUser $targetUser, ?
 			};
 		}
 
-		if ($visibility === ProfileConfig::VISIBILITY_SHOW) {
+		if ($visibility === self::VISIBILITY_SHOW) {
 			if (empty($scope)) {
 				return true;
 			}
@@ -318,12 +318,12 @@ private function getDefaultProfileConfig(IUser $targetUser, ?IUser $visitingUser
 		// Construct the default config for actions
 		$actionsConfig = [];
 		foreach ($this->getActions($targetUser, $visitingUser) as $action) {
-			$actionsConfig[$action->getId()] = ['visibility' => ProfileConfig::DEFAULT_VISIBILITY];
+			$actionsConfig[$action->getId()] = ['visibility' => self::DEFAULT_VISIBILITY];
 		}
 
 		// Construct the default config for account properties
 		$propertiesConfig = [];
-		foreach (ProfileConfig::DEFAULT_PROPERTY_VISIBILITY as $property => $visibility) {
+		foreach (self::DEFAULT_PROPERTY_VISIBILITY as $property => $visibility) {
 			$propertiesConfig[$property] = ['visibility' => $visibility];
 		}