-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Closed
Labels
4. to releaseReady to be released and/or waiting for tests to finishReady to be released and/or waiting for tests to finishbugregression
Milestone
Description
Steps to reproduce
- Setup NC from master (2b36842)
- Enable spreed app from master
- Create a file
- Share it with other people
- Open the sidebar for that file
- Click on "Versions"
- Click on "Talk"
Expected result
Versions tab loads correctly.
Talk tab exists.
Actual result
JS issues:
Tab.js:52 Uncaught Error: The id argument is not a valid string
at new e (Tab.js:52)
at mainFilesSidebarLoader.js:49
Versions tab spinner stays, JS error:
versioncollection.js:61 Uncaught (in promise) TypeError: this._fileInfo.getFullPath is not a function
at i.parse (versioncollection.js:61)
at i.set (backbone.js:839)
at Object.e.success (backbone.js:1059)
at backbone-webdav.js:174
Talk tab does not appear at all!
Versions
NC 21.0.0 alpha git master 2b36842
Talk app git master acaf9aac3fec3b9e99c2a1e685127470501ee74d
Analysis
It seems that the FileInfo object passed in for the versions is of the wrong class OC.Files.FileInfo as it doesn't have getFullPath(). The correct object should be of type OCA.Files.FileInfoModel
@skjnldsv I heard you might have an idea or have touched this bit recently ?
(happy to help with the analysis if needed)
Metadata
Metadata
Assignees
Labels
4. to releaseReady to be released and/or waiting for tests to finishReady to be released and/or waiting for tests to finishbugregression