Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Undefined array key "storage_string_id" at /apps/files_sharing/lib/SharedStorage.php#483 #50235

Open
6 of 8 tasks
alx-tuilmenau opened this issue Jan 17, 2025 · 6 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug

Comments

@alx-tuilmenau
Copy link
Contributor

⚠️ This issue respects the following points: ⚠️

Bug description

After updating from 29.0.10 to 29.0.11.1, I got lots of errors in the Nextcloud logfile, all of the same kind for a WebDAV PROPFIND operation with different filenames.

Steps to reproduce

  1. Update to 29.0.11
  2. Sync files via WebDAV
  3. See logfile

Expected behavior

No errors in log

Nextcloud Server version

29

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 28.0.1 to 28.0.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "XXX",
            "XXX"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "29.0.11.1",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "dbdriveroptions": {
            "1002": "SET wait_timeout = 28800"
        },
        "installed": true,
        "default_language": "de",
        "updatechecker": true,
        "has_internet_connection": true,
        "memcached_servers": [
            [
                "localhost",
                11211
            ]
        ],
        "appstoreenabled": true,
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
        "loglevel": 2,
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "forwarded_for_headers": [
            "HTTP_X_FORWARDED_FOR"
        ],
        "overwritehost": "XXX",
        "overwriteprotocol": "https",
        "overwrite.cli.url": "XXX",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "skeletondirectory": "\/data\/nextcloud_skel",
        "activity_expire_days": 14,
        "integrity.check.disabled": true,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379,
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "knowledgebaseenabled": false,
        "defaultapp": "",
        "sharing.minSearchStringLength": 4,
        "sharing.maxAutocompleteResults": 5,
        "maintenance": false,
        "debug": false,
        "htaccess.RewriteBase": "\/",
        "proxy": "XXX",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "updater.release.channel": "stable",
        "lookup_server": "",
        "app_install_overwrite": [
            "quotaadmin",
            "drop_account",
            "gpxedit",
            "twofactor_u2f",
            "metadata",
            "files_mindmap"
        ],
        "enable_previews": true,
        "preview_max_x": 700,
        "preview_max_y": 700,
        "preview_max_scale_factor": 2,
        "tempdirectory": "\/data\/tmp\/nextcloud",
        "localstorage.allowsymlinks": true,
        "hashingMemoryCost": 8,
        "default_phone_region": "de",
        "upgrade.disable-web": true,
        "preview_max_filesize_image": 20,
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown"
        ],
        "profile.enabled": false,
        "lost_password_link": "disabled",
        "bulkupload.enabled": false,
        "trashbin_retention_obligation": "auto, 14",
        "versions_retention_obligation": "auto, 14",
        "maintenance_window_start": 18,
        "files_no_background_scan": true
    }
}

List of activated Apps

- activity: 2.21.1
  - announcementcenter: 7.0.1
  - bruteforcesettings: 2.9.0
  - calendar: 4.7.16
  - circles: 29.0.0-dev
  - cloud_federation_api: 1.12.0
  - collectives: 2.15.2
  - comments: 1.19.0
  - contacts: 6.0.2
  - contactsinteraction: 1.10.0
  - dav: 1.30.1
  - deck: 1.13.3
  - drawio: 3.0.3
  - drop_account: 2.6.1
  - federatedfilesharing: 1.19.0
  - federation: 1.19.0
  - files: 2.1.1
  - files_antivirus: 5.6.1
  - files_downloadactivity: 1.17.0
  - files_downloadlimit: 2.0.0
  - files_mindmap: 0.0.32
  - files_pdfviewer: 2.10.0
  - files_reminders: 1.2.0
  - files_retention: 1.18.0
  - files_sharing: 1.21.0
  - files_trashbin: 1.19.0
  - files_versions: 1.22.0
  - forms: 4.3.5
  - guests: 3.2.0
  - login_notes: 1.6.1
  - logreader: 2.14.0
  - lookup_server_connector: 1.17.0
  - metadata: 0.21.0
  - notes: 4.11.0
  - notifications: 2.17.0
  - oauth2: 1.17.1
  - photos: 2.5.0
  - polls: 7.2.9
  - provisioning_api: 1.19.0
  - quota_warning: 1.20.0
  - quotaadmin: 0.0.5
  - recommendations: 2.1.0
  - related_resources: 1.4.0
  - serverinfo: 1.19.0
  - settings: 1.12.0
  - sharebymail: 1.19.0
  - spreed: 19.0.12
  - systemtags: 1.19.0
  - tables: 0.8.3
  - tasks: 0.16.1
  - text: 3.10.1
  - theming: 2.4.0
  - theming_customcss: 1.18.0
  - twofactor_backupcodes: 1.18.0
  - twofactor_totp: 11.0.0-dev
  - twofactor_webauthn: 1.4.0
  - updatenotification: 1.19.1
  - user_ldap: 1.20.0
  - viewer: 2.3.0
  - whiteboard: 1.0.4
  - workflowengine: 2.11.0

Nextcloud Signing status

Integrity checker has been disabled. Integrity cannot be verified.

Nextcloud Logs

{"reqId":"XXX","level":3,"time":"2025-01-17T13:43:47+00:00","remoteAddr":"XXX","user":"XXX","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/fXXX","message":"Undefined array key \"storage_string_id\" at /data/nextcloud_a2/apps/files_sharing/lib/SharedStorage.php#483","userAgent":"Mozilla/5.0 (Linux) mirall/3.12.0-20240214.183952.1c1e752c4-1.0~jammy1 (Nextcloud, ubuntu-6.5.0-21-generic ClientArchitecture: x86_64 OsArchitecture: x86_64)","version":"29.0.11.1","data":{"app":"PHP"}}

Additional info

The code at the error position is this:

$node = $this->getShare()->getNodeCacheEntry();
if ($node instanceof CacheEntry) {
           $storageId = $node->getData()['storage_string_id'];  // <---- error line

I tried to find something, but the $node there does not contain the key storage_string_id, it looks like there are only the columns from the filecache table, so only the numerical storageid is there. I don't know where this is generated / comes from, the $this->getShare() returns a IShare supershare attribute, which is set via $arguments in the constructor, so I don't know how to fix it.

@alx-tuilmenau alx-tuilmenau added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 17, 2025
@kesselb
Copy link
Contributor

kesselb commented Jan 17, 2025

cc @icewind1991 @juliusknorr

@alx-tuilmenau
Copy link
Contributor Author

alx-tuilmenau commented Jan 17, 2025

Maybe it is caused by this change: 926b9d3

Edit: Reverting this change seems to solve the problem, but I don't know if this will break something other elsewhere.

@gonzalo

This comment has been minimized.

@gonzalo
Copy link
Contributor

gonzalo commented Jan 20, 2025

I literally have thousands of errors since updated to 30.0.5. All migrations and complementary db operations have ben ran.

@gonzalo
Copy link
Contributor

gonzalo commented Jan 21, 2025

This is my report

⚠️ This issue respects the following points: ⚠️

Bug description

Same as above mentioned. Thousands of errors like this. Lots of my users use webdav to get data from our nextcloud instance. But also navigator request seems to be affected.

[PHP] Error: Undefined array key "storage_string_id" at /xxxxxxxxxxxxxxxxxxx/nextcloud/apps/files_sharing/lib/SharedStorage.php#459
PROPFIND /remote.php/dav/files/xxxxxxxxxxx/Espai_xxxxxxxxx/xxxxxxxxx/xxxxxxx/csv-MINISTERIO
de 172.16.198.206 por [email protected] a las 21 ene 2025, 8:52:56
{"reqId":"xxxxxxxxxx","level":3,"time":"2025-01-21T07:52:56+00:00","remoteAddr":"172.16.xxxxxx","user":"[email protected]","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/xxxxxxxxxx/......../xxxxxxxxxxxx","message":"Undefined array key "storage_string_id" at /xxxxxxxxxxxx/nextcloud/apps/files_sharing/lib/SharedStorage.php#459","userAgent":"Microsoft-WebDAV-MiniRedir/10.0.19045","version":"30.0.5.1","data":{"app":"PHP"},"id":"xxxxxxxxxxx"}

{"reqId":"xxxxx","level":3,"time":"2025-01-21T08:22:45+00:00","remoteAddr":"10.17.xxxxxx","user":"xxxxxxxxx","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/mxxxxxxxxxxx/","message":"Undefined array key "storage_string_id" at /xxxxxxxxxxxxxxxx/nextcloud/apps/files_sharing/lib/SharedStorage.php#459","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36","version":"30.0.5.1","data":{"app":"PHP"}}

{"reqId":"xxxxxx","level":3,"time":"2025-01-21T08:24:20+00:00","remoteAddr":"10.17.xxxxxxx","user":"xxxxxxxx","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/xxxxxxxxxxxxxxxxxx","message":"Undefined array key "storage_string_id" at /aplica/nextcloud/www/nextcloud/apps/files_sharing/lib/SharedStorage.php#459","userAgent":"Mozilla/5.0 (Windows) mirall/3.15.3 (build 20250107) (Nextcloud, windows-10.0.22631 ClientArchitecture: x86_64 OsArchitecture: x86_64)","version":"30.0.5.1","data":{"app":"PHP"}}

Steps to reproduce

not sure. Just happening afte upgrade form 29 to 30

Expected behavior

No errors on logs

Nextcloud Server version

30

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 28 to 29)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "nexe.ua.es"
        ],
        "default_language": "es",
        "default_locale": "es_ES",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "tempdirectory": "\/filestore\/temp",
        "version": "30.0.5.1",
        "overwrite.cli.url": "https:\/\/nexe.ua.es",
        "htaccess.RewriteBase": "\/",
        "dbtype": "mysql",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "filelocking.enabled": true,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "dbindex": 0
        },
        "default_phone_region": "ES",
        "maintenance": false,
        "maintenance_window_start": 1,
        "theme": "",
        "activity_expire_days": 60,
        "loglevel": 3,
        "log_type": "file",
        "logfile": "\/aplicalog\/nextcloud_logs\/nextcloud.log",
        "log_type_audit": "file",
        "logfile_audit": "\/aplicalog\/nextcloud_logs\/audit.log",
        "log.condition": {
            "apps": [
                "admin_audit"
            ]
        },
        "installed": true,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "updater.release.channel": "stable",
        "lost_password_link": "disabled",
        "defaultapp": "files",
        "allow_user_to_change_display_name": false,
        "hide_login_form": false,
        "skeletondirectory": "\/aplica\/nextcloud\/www\/assets\/skeleton",
        "templatedirectory": "\/aplica\/nextcloud\/www\/assets\/templates",
        "session_lifetime": 28800,
        "twofactor_enforced": "true",
        "twofactor_enforced_groups": [
            "2FA_enforced"
        ],
        "twofactor_enforced_excluded_groups": [
            "PAS",
            "PDI"
        ],
        "profile.enabled": false,
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap"
        ],
        "app_install_overwrite": [
            "sharelisting"
        ],
        "simpleSignUpLink.shown": false,
        "config_is_read_only": true
    }
}

List of activated Apps

Enabled:
  - activity: 3.0.0
  - admin_audit: 1.20.0
  - announcementcenter: 7.1.0
  - app_api: 4.0.5
  - calendar: 5.0.9
  - circles: 30.0.0
  - cloud_federation_api: 1.13.0
  - comments: 1.20.1
  - contacts: 6.1.3
  - contactsinteraction: 1.11.0
  - dashboard: 7.10.0
  - dav: 1.31.1
  - deck: 1.14.3
  - federatedfilesharing: 1.20.0
  - federation: 1.20.0
  - files: 2.2.0
  - files_accesscontrol: 1.20.1
  - files_downloadlimit: 3.0.0
  - files_pdfviewer: 3.0.0
  - files_reminders: 1.3.0
  - files_sharing: 1.22.0
  - files_trashbin: 1.20.1
  - files_versions: 1.23.0
  - impersonate: 1.17.1
  - logreader: 3.0.0
  - lookup_server_connector: 1.18.0
  - nextcloud_announcements: 2.0.0
  - notifications: 3.0.0
  - oauth2: 1.18.1
  - password_policy: 2.0.0
  - photos: 3.0.2
  - privacy: 2.0.0
  - provisioning_api: 1.20.0
  - recommendations: 3.0.0
  - related_resources: 1.5.0
  - richdocuments: 8.5.3
  - serverinfo: 2.0.0
  - settings: 1.13.0
  - sharebymail: 1.20.0
  - sharelisting: 1.2.0
  - spreed: 20.1.3
  - support: 2.0.0
  - systemtags: 1.20.0
  - text: 4.1.0
  - theming: 2.5.0
  - twofactor_backupcodes: 1.19.0
  - twofactor_totp: 12.0.0-dev
  - updatenotification: 1.20.0
  - user_saml: 6.4.1
  - user_status: 1.10.0
  - user_usage_report: 1.14.0
  - viewer: 3.0.0
  - webhook_listeners: 1.1.0-dev
  - workflowengine: 2.12.0
Disabled:
  - bruteforcesettings: 3.0.0 (installed 3.0.0)
  - encryption: 2.18.0
  - files_external: 1.22.0
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - firstrunwizard: 3.0.0 (installed 2.14.0)
  - survey_client: 2.0.0 (installed 1.13.0)
  - suspicious_login: 8.0.0
  - twofactor_nextcloud_notification: 4.0.0
  - user_ldap: 1.21.0
  - weather_status: 1.10.0 (installed 1.5.0)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

{"reqId":"sdsZfPdSU8vSMkpA01U2","level":3,"time":"2025-01-21T08:27:20+00:00","remoteAddr":"172.28.***.***","user":"laura.******","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/*****/Espai_SA_Titols/Copia%20Electr%C3%B3nica/OFICIALES/SET/2024/Septiembre","message":"Undefined array key \"storage_string_id\" at /.../nextcloud/apps/files_sharing/lib/SharedStorage.php#459","userAgent":"Microsoft-WebDAV-MiniRedir/10.0.19045","version":"30.0.5.1","data":{"app":"PHP"}}
{"reqId":"WXjFN35daqStFUTVIR0c","level":3,"time":"2025-01-21T08:27:20+00:00","remoteAddr":"172.28.***.***","user":"laura.******","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/*****/Espai_SA_Titols/Copia%20Electr%C3%B3nica/OFICIALES/SET/2024/Septiembre","message":"Undefined array key \"storage_string_id\" at /.../nextcloud/apps/files_sharing/lib/SharedStorage.php#459","userAgent":"Microsoft-WebDAV-MiniRedir/10.0.19045","version":"30.0.5.1","data":{"app":"PHP"}}
{"reqId":"2orQEnq5sWJ3YJ0VZN6z","level":3,"time":"2025-01-21T08:27:21+00:00","remoteAddr":"172.28.***.***","user":"laura.******","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/*****/Espai_SA_Titols/Copia%20Electr%C3%B3nica/OFICIALES/SET/2024/Octubre","message":"Undefined array key \"storage_string_id\" at /.../nextcloud/apps/files_sharing/lib/SharedStorage.php#459","userAgent":"Microsoft-WebDAV-MiniRedir/10.0.19045","version":"30.0.5.1","data":{"app":"PHP"}}
{"reqId":"Kg0qK8M3MaOl4iIs0heP","level":3,"time":"2025-01-21T08:27:21+00:00","remoteAddr":"172.28.***.***","user":"laura.******","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/*****/Espai_SA_Titols/Copia%20Electr%C3%B3nica/OFICIALES/SET/2024/Octubre","message":"Undefined array key \"storage_string_id\" at /.../nextcloud/apps/files_sharing/lib/SharedStorage.php#459","userAgent":"Microsoft-WebDAV-MiniRedir/10.0.19045","version":"30.0.5.1","data":{"app":"PHP"}}
{"reqId":"xD73j7HK5hxEMVLxY4Yq","level":3,"time":"2025-01-21T08:27:21+00:00","remoteAddr":"172.17.***.***","user":"marcos.*****","app":"PHP","method":"GET","url":"/remote.php/dav/files/*****/Espai_SGP_PI/NOMINAS/2025/01.25/altas/remisionpersonal_ipas57_24.pdf","message":"Undefined array key \"storage_string_id\" at /.../nextcloud/apps/files_sharing/lib/SharedStorage.php#459","userAgent":"Microsoft-WebDAV-MiniRedir/10.0.19045","version":"30.0.5.1","data":{"app":"PHP"}}
{"reqId":"FOfSARgtK3obgrQKgUXb","level":3,"time":"2025-01-21T08:27:21+00:00","remoteAddr":"172.17.***.***","user":"marcos.*****","app":"PHP","method":"PROPFIND","url":"/remote.php/dav/files/*****/Espai_SGP_PI/teletrabajo/2025/khaylina_anastasia/_415_1232930_TELETRABAJO_A_KT.PDF","message":"Undefined array key \"storage_string_id\" at /.../nextcloud/apps/files_sharing/lib/SharedStorage.php#459","userAgent":"Microsoft-WebDAV-MiniRedir/10.0.19045","version":"30.0.5.1","data":{"app":"PHP"}}

Additional info

No response

@baltaner
Copy link

Same here
after update from 30.0.4 to 30.0.5
php8.3-fpm, apache2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 29-feedback bug
Projects
None yet
Development

No branches or pull requests

5 participants