-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflowengine "The given regular expression is invalid" #23666
Comments
Thanks for reporting 👍 I see the same issue on Nextcloud 19. cc @juliushaertl @blizzz as 'httpd/unix-directory' is not a pattern they cannot use matches as operator. We should probably hide operators which are not compatible to each other. We have the same issue the other way around for |
Hi since the number of reported issues at the |
Cool 👍
A pinned FAQ issue might help with that. At least here at nextcloud/server it helps a bit. |
Thanks for the hint, will give it a try 😄 So basically i'd implement it the following way (given that the first column is set to
Would that be the way to go @kesselb ? |
@R0Wi generally that sounds good to me. On a second thought, it is quite technical for the end user. An admin might now about regex's and stuff, but for the average user "is (not)" or "matches (not)" or the meaning of it is black magic. The best way would be to eliminate the differences (only keep That would be a bigger change however, and not backportable. This is an advantage of your suggestion, so let's go with it. Changing the UI more radically (it has effects on the backend bits, too) could be something for 22. |
I suppose this is still valid on NC21.0.2? |
AFAIK unfortunately yes. Did not manage to create a PR, yet 😢 |
NC 21.0.3 Workflow OCR 1.21.1, the problem still persists. The only way to deal with this, for now, is to remove the other conditional, in my case, it was file MIME = pdf. |
@kesselb did you ever get around to doing this? |
Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you! My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort! If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+ |
I dont have an issue with this anymore in general as after reading all this back when I had the issue I just know what I need to click and what that error actually means... |
Actually, when you choose "custom MIME type" you are facing a similar error. But this is a bogus user-interface: the placeholder suggests that you just can add "e.g. http/unix-directory". However, the placeholder suggestion is wrong, you need to enter a full-fledged regular expression, i.e. I have no problems with entering a regular expression, but neither the placeholder nor the cryptic error message I experienced this with a up-to-date v25 NC. Screenshots are appended |
Still valid for NC 27.1.3 |
fixes #23666 Signed-off-by: Robin Windey <[email protected]>
fixes #23666 Signed-off-by: Robin Windey <[email protected]>
Steps to reproduce
File MIME type
matches
(ordoes not match
)PDF documents
(orFolder
)Expected behaviour
Workflow can be created
Actual behaviour
If i try to save the workflow an error message is raised "The given regular expression is invalid"
Server configuration
Operating system: Ubuntu 20.04
Web server: Apache2
Database: MySql 8.0
PHP version: 7.4
Nextcloud version: 20.0.1
Additional information
server/apps/workflowengine/lib/Check/AbstractStringCheck.php
Line 91 in 2a154f5
server/apps/workflowengine/src/components/Checks/FileMimeType.vue
Line 72 in 2a154f5
server/apps/workflowengine/src/components/Checks/FileMimeType.vue
Line 87 in 2a154f5
Currently there is also an open issue at R0Wi-DEV/workflow_ocr#32 where multiple users reported this problem.
The text was updated successfully, but these errors were encountered: