perf: Optimize downloading directories as zip to avoid counting files for zip64 #56113
+7
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
Altahrim,
ArtificialOwl,
icewind1991,
susnux and
yemkareems
and removed request for
a team
juliusknorr
force-pushed
the
perf/zip-download
branch
from
6419ea7 to
9460f38
Compare
susnux
reviewed
Oct 31, 2025
susnux
reviewed
Oct 31, 2025
… for zip64 Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
perf/zip-download
branch
from
9460f38 to
d861c1d
Compare
Member
Author
|
Bump for reviews, would be great to get this in for 33 |
susnux
approved these changes
Dec 18, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Maybe short cut it even more:
Use zip64 always
| } | ||
|
|
||
| $streamer = new Streamer($tarRequest, -1, count($content), $this->timezoneFactory); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading large amount of files as ZIP, we may spend time counting files and holding them in memory. The only reason for this is to determine if zip32 or zip64 shall be used.
We can take a shortcut to always use zip64. Support for zip32 can be dropped as all clients should support opening zip64 these days