feat(settings): persist user management column visibility #57079
Conversation
Pringels
requested review from
CarlSchwan,
artonge,
come-nc,
icewind1991,
skjnldsv and
susnux
and removed request for
a team
Pringels
force-pushed
the
enhancement/15632/persist-user-management-columns
branch
from
d322e65 to
c9a45f8
Compare
Pringels
force-pushed
the
enhancement/15632/persist-user-management-columns
branch
2 times, most recently
from
37418ed to
00002fc
Compare
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
The move away from IConfig is somewhat necessary, because it is deprecated usage and we block adding any new code that uses deprecated code. You can check that locally by running psalm.
Pringels
force-pushed
the
enhancement/15632/persist-user-management-columns
branch
from
d881697 to
4039847
Compare
|
Will squash and sign off again shortly |
Pringels
force-pushed
the
enhancement/15632/persist-user-management-columns
branch
from
f065327 to
20c7a45
Compare
Pringels
force-pushed
the
enhancement/15632/persist-user-management-columns
branch
from
2696436 to
3d19865
Compare
|
@Pringels psalm seems unhappy, can you look into it? It might only be a matter of rebasing |
Previously, column visibility settings were stored in localStorage, causing them to be lost when logging out or switching browsers. This change moves the persistence to the database as user preferences. It also refactors the frontend to use clean `userList.*` keys for better consistency between the store and the API. Signed-off-by: Peter Ringelmann <[email protected]>
Signed-off-by: Peter Ringelmann <[email protected]>
Signed-off-by: Peter Ringelmann <[email protected]>
Signed-off-by: Peter Ringelmann <[email protected]>
Pringels
force-pushed
the
enhancement/15632/persist-user-management-columns
branch
from
d464ef0 to
6a9be2e
Compare
Fixed - I think something went wrong with my previous rebase. Psalm is happy again when I run it locally 🙂 |
|
I see there's a cypress test failing related to my changes. Looking into it. 
|
Signed-off-by: Peter Ringelmann <[email protected]>
|
Ah I noticed the 
|
|
The other failing cypress test might be flaky since it passes locally and seems unrelated |
|
Thank you @Pringels for the fix and for being reactive until the end :) |
3 participants
Summary
Moves user management column settings (like showing the storage path) from
localStorageto the database (in user preferences). This ensures configuration persists across browsers, sessions, and devices.Also refactors the users Vuex store to decouple internal state properties from backend configuration keys, simplifying state management and improving maintainability.
Checklist
3. to review, feature component)stable32)