Skip to content

Conversation

@enriquepablo
Copy link

@enriquepablo enriquepablo commented Dec 17, 2025

Summary

This is a preliminary PR for discussion. If this goes through there are some things missing with which we'll be grateful to get some guidance:

  • docs and tests
  • keeping retrieved access tokens in the db
  • removing tokens when removing shares (will depend on the previous point)

Also this depends on a pending PR for Guzzle:

guzzle/guzzle#3310

@enriquepablo enriquepablo requested a review from a team as a code owner December 17, 2025 16:33
@enriquepablo enriquepablo requested review from Altahrim, ArtificialOwl, CarlSchwan and salmart-dev and removed request for a team December 17, 2025 16:33
use Sabre\DAV\Xml\Property\ResourceType;
use Sabre\HTTP\ClientException;
use Sabre\HTTP\ClientHttpException;
use Sabre\HTTP\RequestInterface;
Copy link
Author

@enriquepablo enriquepablo Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake breaking up the code into commits, the missing open-comment is added in a later commit:

bcf7ea1#diff-53ee4c908f9ae3a27e45d03c57ac5ed83c5916d7260561a03f279880671f6155R42

Sorry about this, I'll re-arrange a fixed pr asap.

@enriquepablo
Copy link
Author

I'm closing this, fixing the above issue, an opening a new PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant