-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Adapt to OCM spec for remote shares #57153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to use as bearer token
| use Sabre\DAV\Xml\Property\ResourceType; | ||
| use Sabre\HTTP\ClientException; | ||
| use Sabre\HTTP\ClientHttpException; | ||
| use Sabre\HTTP\RequestInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mistake breaking up the code into commits, the missing open-comment is added in a later commit:
bcf7ea1#diff-53ee4c908f9ae3a27e45d03c57ac5ed83c5916d7260561a03f279880671f6155R42
Sorry about this, I'll re-arrange a fixed pr asap.
|
I'm closing this, fixing the above issue, an opening a new PR |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
This is a preliminary PR for discussion. If this goes through there are some things missing with which we'll be grateful to get some guidance:
Also this depends on a pending PR for Guzzle:
guzzle/guzzle#3310