diff --git a/apps/files_trashbin/lib/Trashbin.php b/apps/files_trashbin/lib/Trashbin.php
index 7299326ecf11a..15d5cd73a12dc 100644
--- a/apps/files_trashbin/lib/Trashbin.php
+++ b/apps/files_trashbin/lib/Trashbin.php
@@ -16,7 +16,6 @@
use OC\Files\View;
use OC\User\NoUserException;
use OC_User;
-use OCA\Files_Trashbin\AppInfo\Application;
use OCA\Files_Trashbin\Command\Expire;
use OCA\Files_Trashbin\Events\BeforeNodeRestoredEvent;
use OCA\Files_Trashbin\Events\NodeRestoredEvent;
@@ -844,7 +843,7 @@ public static function expire($user) {
$dirContent = Helper::getTrashFiles('/', $user, 'mtime');
// delete all files older then $retention_obligation
- [$delSize, $count] = self::deleteExpiredFiles($dirContent, $user, $availableSpace <= 0);
+ [$delSize, $count] = self::deleteExpiredFiles($dirContent, $user);
$availableSpace += $delSize;
@@ -857,9 +856,7 @@ public static function expire($user) {
*/
private static function scheduleExpire($user) {
// let the admin disable auto expire
- /** @var Application $application */
- $application = Server::get(Application::class);
- $expiration = $application->getContainer()->query('Expiration');
+ $expiration = Server::get(Expiration::class);
if ($expiration->isEnabled()) {
Server::get(IBus::class)->push(new Expire($user));
}
@@ -875,14 +872,12 @@ private static function scheduleExpire($user) {
* @return int|float size of deleted files
*/
protected static function deleteFiles(array $files, string $user, int|float $availableSpace): int|float {
- /** @var Application $application */
- $application = Server::get(Application::class);
- $expiration = $application->getContainer()->query('Expiration');
+ $expiration = Server::get(Expiration::class);
$size = 0;
- if ($availableSpace < 0) {
+ if ($availableSpace <= 0) {
foreach ($files as $file) {
- if ($availableSpace < 0 && $expiration->isExpired($file['mtime'], true)) {
+ if ($availableSpace <= 0 && $expiration->isExpired($file['mtime'], true)) {
$tmp = self::delete($file['name'], $user, $file['mtime']);
Server::get(LoggerInterface::class)->info(
'remove "' . $file['name'] . '" (' . $tmp . 'B) to meet the limit of trash bin size (50% of available quota) for user "{user}"',
@@ -906,18 +901,16 @@ protected static function deleteFiles(array $files, string $user, int|float $ava
*
* @param array $files list of files sorted by mtime
* @param string $user
- * @param bool $quotaExceeded
* @return array{int|float, int} size of deleted files and number of deleted files
*/
- public static function deleteExpiredFiles($files, $user, bool $quotaExceeded = false) {
- /** @var Expiration $expiration */
+ public static function deleteExpiredFiles($files, $user) {
$expiration = Server::get(Expiration::class);
$size = 0;
$count = 0;
foreach ($files as $file) {
$timestamp = $file['mtime'];
$filename = $file['name'];
- if ($expiration->isExpired($timestamp, $quotaExceeded)) {
+ if ($expiration->isExpired($timestamp)) {
try {
$size += self::delete($filename, $user, $timestamp);
$count++;
diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml
index b198266da15c6..7e3f9ab604ce3 100644
--- a/build/psalm-baseline.xml
+++ b/build/psalm-baseline.xml
@@ -1907,8 +1907,6 @@
-
-