fix: adjust public page footer logic #57348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianKrupinski
requested review from
come-nc,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
come-nc
requested changes
Jan 6, 2026
nickvergessen
approved these changes
Jan 7, 2026
Antreesy
approved these changes
Jan 7, 2026
Contributor
There was a problem hiding this comment.
For the record, comparison with the original condition (before the 55415):
- <?php if (isset($template) && $template->getFooterVisible() && ($theme->getLongFooter() !== '' || $_['showSimpleSignUpLink'])) { ?>
+ <?php if ((!isset($template) || $template->getFooterVisible() !== false) && ($theme->getLongFooter() !== '' || $_['showSimpleSignUpLink'])) { ?>
6 tasks
Merged
Contributor
Author
|
Does this address the issue you had? |
Contributor
Yes, tested for public rooms and call recordings in Talk |
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
force-pushed
the
fix/adjust-public-page-footer-logic
branch
from
defe392 to
6b3d3fd
Compare
Contributor
Author
|
/backport to stable32 |
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)