Skip to content

Make share mount provider authoritative #57523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
icewind1991 wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Make share mount provider authoritative #57523

icewind1991 wants to merge 6 commits into from
+487 −403

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Jan 13, 2026 •
edited
Loading

@icewind1991 icewind1991 added this to the Nextcloud 33 milestone Jan 13, 2026
@icewind1991 icewind1991 requested review from a team as code owners January 13, 2026 15:15
@icewind1991 icewind1991 added the 2. developing Work in progress label Jan 13, 2026
@icewind1991 icewind1991 requested review from leftybournes, nfebe, sorbaugh, susnux, szaimen and yemkareems and removed request for a team January 13, 2026 15:15
@icewind1991 icewind1991 changed the title Authoritative share provider Make share mount provider authoritative Jan 13, 2026
@szaimen szaimen requested review from artonge, come-nc and salmart-dev and removed request for szaimen January 13, 2026 15:19
@icewind1991 icewind1991 marked this pull request as draft January 13, 2026 15:19
@icewind1991 icewind1991 force-pushed the authoritative-share-provider branch from c553582 to 8791ff4 Compare January 13, 2026 15:38
@icewind1991 icewind1991 mentioned this pull request Jan 13, 2026
Closed
3 tasks
@icewind1991 icewind1991 force-pushed the authoritative-share-provider branch 10 times, most recently from 5d5b8d8 to 7181fa5 Compare January 16, 2026 10:24
@artonge artonge mentioned this pull request Jan 21, 2026
Open
@icewind1991 icewind1991 force-pushed the authoritative-share-provider branch from 7181fa5 to bac9196 Compare January 21, 2026 15:06
@icewind1991
feat: perform share mount validation on share instead of on mount
d71c679 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: attempt to make share conflict resolution more resilient to fals…
43a9335 
…e positives

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: adjust tests
94f3346 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
perf: only update shares for users once
b431506 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: adjust SharesUpdatedListener to event change
34fc215 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: implement authoritative mount provider for share provider
02cc214 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the authoritative-share-provider branch from bac9196 to 02cc214 Compare January 21, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@susnux susnux Awaiting requested review from susnux susnux was automatically assigned from nextcloud/server-frontend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

2. developing Work in progress

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @artonge @CarlSchwan