fix(profile): Check profile config before creating room from guest

Signed-off-by: Joas Schilling <[email protected]>

Author: nickvergessen

lib/Controller/PageController.php

@@ -37,6 +37,7 @@
 use OCA\Talk\TalkSession;
 use OCA\Talk\TInitialState;
 use OCA\Viewer\Event\LoadViewer;
+use OCP\Accounts\IAccountManager;
 use OCP\App\IAppManager;
 use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http;
@@ -67,6 +68,7 @@
 use OCP\IUserSession;
 use OCP\L10N\IFactory;
 use OCP\Notification\IManager as INotificationManager;
+use OCP\Profile\IProfileManager;
 use OCP\Security\Bruteforce\IThrottler;
 use OCP\Security\RateLimiting\ILimiter;
 use OCP\Security\RateLimiting\IRateLimitExceededException;
@@ -98,6 +100,7 @@ public function __construct(
 		IConfig $serverConfig,
 		IGroupManager $groupManager,
 		protected IUserManager $userManager,
+		protected IProfileManager $profileManager,
 		protected ILimiter $limiter,
 		protected IFactory $l10nFactory,
 	) {
@@ -150,25 +153,26 @@ public function duplicateSession(): Response {
 		return $this->index();
 	}
 
-	protected function createPrivateRoom(string $targetUserId): ?Room {
+	/**
+	 * @throws \InvalidArgumentException
+	 */
+	protected function createPrivateRoom(string $targetUserId): Room {
 		$user = $this->userManager->get($targetUserId);
 		if (!$user instanceof IUser) {
-			return null;
+			throw new \InvalidArgumentException('user');
 		}
 
-		$l = $this->l10nFactory->get('spreed', $this->l10nFactory->getUserLanguage($user));
-
-		try {
-			$room = $this->roomService->createConversation(
-				Room::TYPE_PUBLIC,
-				$l->t('Contact request'),
-				$user,
-			);
-		} catch (\InvalidArgumentException) {
-			return null;
+		if ($this->profileManager->isProfileFieldVisible('talk', $user, null)) {
+			throw new \InvalidArgumentException('profile');
 		}
 
-		return $room;
+		$l = $this->l10nFactory->get('spreed', $this->l10nFactory->getUserLanguage($user));
+
+		return $this->roomService->createConversation(
+			Room::TYPE_PUBLIC,
+			$l->t('Contact request'),
+			$user,
+		);
 	}
 
 	/**
@@ -199,8 +203,9 @@ public function index(string $token = '', string $callUser = '', string $passwor
 					return new TooManyRequestsResponse();
 				}
 
-				$room = $this->createPrivateRoom($callUser);
-				if ($room === null) {
+				try {
+					$room = $this->createPrivateRoom($callUser);
+				} catch (\InvalidArgumentException) {
 					$response = new TemplateResponse('core', '404-profile', [], TemplateResponse::RENDER_AS_GUEST);
 					$response->throttle(['action' => 'callUser', 'callUser' => $callUser]);
 					return $response;