fix(recording): create the recording folder as the owning user

The recording and transcript files are created with the owner as the active
user, but the folder that holds them is created in getRecordingFolder()
outside of that context. For the first recording of a conversation the
folder therefore appears in the activity stream as created by "remote
account", next to the file that is attributed correctly.

Move the user switch into a small runAsUser() helper and use it for the
folder lookup as well, so both the folder and the file are attributed to
the owner.

Signed-off-by: Baki Burak Öğün <burak@burakogun.com>

Author: bakiburakogun

lib/Service/RecordingService.php

@@ -632,16 +632,26 @@ private function validateMimeTypeAndExtension(string $fileName, string $mimeType
 	 * @throws NoUserException
 	 */
 	private function newFileAsUser(string $owner, Folder $folder, string $fileName, $content): File {
+		return $this->runAsUser($owner, function () use ($folder, $fileName, $content): File {
+			return $folder->newFile($fileName, $content);
+		});
+	}
+
+	/**
+	 * Run the callback with the owner as active user, so that file events and
+	 * activities are attributed to them instead of to nobody.
+	 */
+	private function runAsUser(string $owner, callable $callback) {
 		$user = $this->userManager->get($owner);
 		if (!$user instanceof IUser) {
-			return $folder->newFile($fileName, $content);
+			return $callback();
 		}
 
 		$previousUser = $this->userSession->getUser();
 		$this->userSession->setUser($user);
 
 		try {
-			return $folder->newFile($fileName, $content);
+			return $callback();
 		} finally {
 			$this->userSession->setUser($previousUser);
 		}
@@ -652,6 +662,16 @@ private function newFileAsUser(string $owner, Folder $folder, string $fileName,
 	 * @throws NoUserException
 	 */
 	private function getRecordingFolder(string $owner, string $token): Folder {
+		return $this->runAsUser($owner, function () use ($owner, $token): Folder {
+			return $this->getRecordingFolderInternal($owner, $token);
+		});
+	}
+
+	/**
+	 * @throws NotPermittedException
+	 * @throws NoUserException
+	 */
+	private function getRecordingFolderInternal(string $owner, string $token): Folder {
 		$userFolder = $this->rootFolder->getUserFolder($owner);
 		$recordingRootFolderName = $this->config->getRecordingFolder($owner);
 		try {