-
Notifications
You must be signed in to change notification settings - Fork 461
📅 Handling of event conversations - ⚙️ API - Follow up #14689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It would be possible to filter the rooms from this modal in Calendar: @ChristophWurst is that a change you would be ok with? |
Which listener? |
The Talk internal listener https://github.com/nextcloud/spreed/blob/main/lib/Listener/CalDavEventListener.php |
I see. What does it do? It sets room meta data to the event start? And if there is more than one event pointing to the same room the start becomes ambiguous? |
Yes, exactly. We want to reduce the items in the room list since we have quite some power users that have hundreds, if not thousands of rooms that are "single use" for a calendar event, so we filter out those types of rooms until we're closer to their start date.
Exactly.
Currently, we don't since we simply overwrite the timestamp when it's a Which is why I would prefer if we could filter rooms that have an objectType |
Some points from our discussion:
Considerations:
|
To Do Development CalDavListener:
|
Follow up to #14402
Imagine a use case where I create a room that is an object type
event
, and then re- use it for a second event by choosing it from the calendar dropdown.The following scenarios are possible:
In most cases, the listener would update the timestamp without checking to see which event is closer to the present.
We also don't keep track of additional events, and we don't handle events with recurrences.
Solution 1: Filter the room list in the Calendar app to only show non- event type rooms
Solution 2: check the above items in the listener and make sure to always use the closest timestamp. This would mean that the event room might be deleted even though it's still in use in a different event, which is also not great.
The text was updated successfully, but these errors were encountered: