Default signaling token algorithm might be unsupported

[blizzz]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. enable this app from master branch
2. go to a conversaiton room
3. try to send a message

When changing the algo from ES256 to RS256 it works.

It seems a user on the forums saw the same behaviour.

Expected behaviour

I can enter my message in this input field

Actual behaviour

The input field is disabled

Talk app

Talk app version: git master

Custom Signaling server configured: no

Custom TURN server configured: no

Custom STUN server configured: no

Browser

Operating system: Arch

Browser name: Firefox/

Browser version: 104

Browser log

Details

``` Internal server error for ocs/v2.php/apps/spreed/api/v3/signaling/settings?token=abcd1234 ```

Server configuration

Operating system: Arch

Web server: Apache

Database: PostgreSQL

PHP version: 8.1

Nextcloud Version: master (25)

Server log (data/nextcloud.log)

Details

{
  "reqId": "5pukMS4WvPpJNEMyGkds",
  "level": 3,
  "time": "2022-08-31T08:16:41+00:00",
  "remoteAddr": "127.0.0.1",
  "user": "master",
  "app": "no app in context",
  "method": "GET",
  "url": "/master/ocs/v2.php/apps/spreed/api/v3/signaling/settings?token=t44thwig",
  "message": "Algorithm not supported",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:104.0) Gecko/20100101 Firefox/104.0",
  "version": "25.0.0.6",
  "exception": {
    "Exception": "DomainException",
    "Message": "Algorithm not supported",
    "Code": 0,
    "Trace": [
      {
        "file": "/srv/http/nextcloud/master/apps-repos/user_saml/3rdparty/vendor/firebase/php-jwt/src/JWT.php",
        "line": 167,
        "function": "sign",
        "class": "Firebase\\JWT\\JWT",
        "type": "::",
        "args": [
          "eyJ0eXAiOiJKV1QiLCJhbGciOiJFUzI1NiJ9.eyJpc3MiOiJodHRwczpcL1wvbmMuemFyYVwvbWFzdGVyXC8iLCJpYXQiOjE2NjE5MzM4MDEsImV4cCI6MTY2MTkzMzg2MSwic3ViIjoibWFzdGVyIiwidXNlcmRhdGEiOnsiZGlzcGxheW5hbWUiOiJQcmltZSBBZG1pbiBYWFYifX0",
          "-----BEGIN PRIVATE KEY-----\nMIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgXH3FokKibrlEZ1E8\n/7X38Xw+rjwErTFSFcRnI7dXq3ihRANCAARx5Z34FcS0s7eOnj3Qx6TYg7RFACjt\nNBCn7UezDACmVUCuGNJlW0cy0APMM2KLB93jNYqyRrqlEP3uJHyFxfE8\n-----END PRIVATE KEY-----\n",
          "ES256"
        ]
      },
      {
        "file": "/srv/http/nextcloud/master/apps-repos/spreed/lib/Config.php",
        "line": 490,
        "function": "encode",
        "class": "Firebase\\JWT\\JWT",
        "type": "::",
        "args": [
          [
            "https://nc.zara/master/",
            1661933801,
            1661933861,
            "master",
            [
              "Prime Admin XXV"
            ]
          ],
          "-----BEGIN PRIVATE KEY-----\nMIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgXH3FokKibrlEZ1E8\n/7X38Xw+rjwErTFSFcRnI7dXq3ihRANCAARx5Z34FcS0s7eOnj3Qx6TYg7RFACjt\nNBCn7UezDACmVUCuGNJlW0cy0APMM2KLB93jNYqyRrqlEP3uJHyFxfE8\n-----END PRIVATE KEY-----\n",
          "ES256"
        ]
      },
      {
        "file": "/srv/http/nextcloud/master/apps-repos/spreed/lib/Config.php",
        "line": 365,
        "function": "getSignalingTicketV2",
        "class": "OCA\\Talk\\Config",
        "type": "->",
        "args": [
          "master"
        ]
      },
      {
        "file": "/srv/http/nextcloud/master/apps-repos/spreed/lib/Controller/SignalingController.php",
        "line": 173,
        "function": "getSignalingTicket",
        "class": "OCA\\Talk\\Config",
        "type": "->",
        "args": [
          2,
          "master"
        ]
      },
      {
        "file": "/srv/http/nextcloud/master/lib/private/AppFramework/Http/Dispatcher.php",
        "line": 225,
        "function": "getSettings",
        "class": "OCA\\Talk\\Controller\\SignalingController",
        "type": "->",
        "args": [
          "t44thwig"
        ]
      },
      {
        "file": "/srv/http/nextcloud/master/lib/private/AppFramework/Http/Dispatcher.php",
        "line": 133,
        "function": "executeController",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->",
        "args": [
          {
            "__class__": "OCA\\Talk\\Controller\\SignalingController"
          },
          "getSettings"
        ]
      },
      {
        "file": "/srv/http/nextcloud/master/lib/private/AppFramework/App.php",
        "line": 172,
        "function": "dispatch",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->",
        "args": [
          {
            "__class__": "OCA\\Talk\\Controller\\SignalingController"
          },
          "getSettings"
        ]
      },
      {
        "file": "/srv/http/nextcloud/master/lib/private/Route/Router.php",
        "line": 298,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::",
        "args": [
          "OCA\\Talk\\Controller\\SignalingController",
          "getSettings",
          {
            "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
          },
          [
            "v3",
            "ocs.spreed.Signaling.getSettings"
          ]
        ]
      },
      {
        "file": "/srv/http/nextcloud/master/ocs/v1.php",
        "line": 62,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->",
        "args": [
          "/ocsapp/apps/spreed/api/v3/signaling/settings"
        ]
      },
      {
        "file": "/srv/http/nextcloud/master/ocs/v2.php",
        "line": 23,
        "args": [
          "/srv/http/nextcloud/master/ocs/v1.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "/srv/http/nextcloud/master/apps-repos/user_saml/3rdparty/vendor/firebase/php-jwt/src/JWT.php",
    "Line": 188,
    "CustomMessage": "--"
  }
}

[blizzz]

It's related to 79c1920 @fancycode

That said, I have no clue whether there is a default algo that works everywhere, but there is the opportunity to deal with it more user friendly.

[fancycode]

Problem is that the user_saml app in your instance also ships the Firebase JWT library but an older version which doesn't seem to support ES256. From your log:

      {
        "file": "/srv/http/nextcloud/master/apps-repos/user_saml/3rdparty/vendor/firebase/php-jwt/src/JWT.php",
        "line": 167,
        "function": "sign",
        "class": "Firebase\\JWT\\JWT",
        "type": "::",
        "args": [
          "eyJ0eXAiOiJKV1QiLCJhbGciOiJFUzI1NiJ9.eyJpc3MiOiJodHRwczpcL1wvbmMuemFyYVwvbWFzdGVyXC8iLCJpYXQiOjE2NjE5MzM4MDEsImV4cCI6MTY2MTkzMzg2MSwic3ViIjoibWFzdGVyIiwidXNlcmRhdGEiOnsiZGlzcGxheW5hbWUiOiJQcmltZSBBZG1pbiBYWFYifX0",
          "-----BEGIN PRIVATE KEY-----\nMIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgXH3FokKibrlEZ1E8\n/7X38Xw+rjwErTFSFcRnI7dXq3ihRANCAARx5Z34FcS0s7eOnj3Qx6TYg7RFACjt\nNBCn7UezDACmVUCuGNJlW0cy0APMM2KLB93jNYqyRrqlEP3uJHyFxfE8\n-----END PRIVATE KEY-----\n",
          "ES256"
        ]
      },

While we could change the default to RS256 there might be other problems if Talk is implemented against a newer version of JWT but then an older version is used. Is there a way to force Talk to use the own included Firebase library?

[blizzz]

Ha, i should have paid more attention to this detail! Ok, so we're in Depdency Hell land. I think mail had a similar issue and are using webmozart or something to capsulate the deps: https://github.com/nextcloud/mail/blob/main/composer.json#L63-L89

[blizzz]

Christoph blogged about it actually: https://blog.wuc.me/2020/05/13/rock-me-amadeus-php-dependency-hell.html, along with a forum post https://help.nextcloud.com/t/escaping-the-dependency-hell/81407

[nickvergessen]

Off we go.