From 339ae59438852c8ce0e798f3560add7f33b08797 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Tue, 2 Sep 2025 21:33:38 +0200 Subject: [PATCH 1/8] fix: Remove leftover from previous algorithm version MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Daniel Calviño Sánchez --- src/components/CallView/shared/TranscriptBlock.vue | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/components/CallView/shared/TranscriptBlock.vue b/src/components/CallView/shared/TranscriptBlock.vue index 7e8df1ae275..a0034819659 100644 --- a/src/components/CallView/shared/TranscriptBlock.vue +++ b/src/components/CallView/shared/TranscriptBlock.vue @@ -229,13 +229,6 @@ export default { for (let i = lastKnownChunkIndex + 1; i < this.$refs.chunks.length; i++) { const nextChunkElement = this.$refs.chunks[i] - // Separators are inline rather than inline-block, so they have - // different top and bottom boundaries and they should not be - // taken into account. - if (nextChunkElement.classList.contains('separator')) { - continue - } - const nextChunkElementClientRects = nextChunkElement.getClientRects() const nextChunkElementTop = nextChunkElementClientRects[0].top From 29ea0cff4007055fc24866ab84aeb2de28dacfa4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Tue, 2 Sep 2025 21:33:59 +0200 Subject: [PATCH 2/8] fix: Fix type of chunk elements MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Daniel Calviño Sánchez --- src/components/CallView/shared/TranscriptBlock.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/CallView/shared/TranscriptBlock.vue b/src/components/CallView/shared/TranscriptBlock.vue index a0034819659..adf00c68e69 100644 --- a/src/components/CallView/shared/TranscriptBlock.vue +++ b/src/components/CallView/shared/TranscriptBlock.vue @@ -43,7 +43,7 @@ import { getDisplayNameWithFallback } from '../../../utils/getDisplayName.ts' declare module 'vue' { interface TypeRefs { - chunks: undefined | Array + chunks: undefined | Array } interface ComponentCustomProperties { From db430c35e0ec6c939f9d596d8cea21919129610b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Tue, 2 Sep 2025 19:37:00 +0200 Subject: [PATCH 3/8] refactor: Extract object to its own variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Daniel Calviño Sánchez --- .../CallView/shared/LiveTranscriptionRenderer.vue | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/CallView/shared/LiveTranscriptionRenderer.vue b/src/components/CallView/shared/LiveTranscriptionRenderer.vue index fee333d115d..f37b652962c 100644 --- a/src/components/CallView/shared/LiveTranscriptionRenderer.vue +++ b/src/components/CallView/shared/LiveTranscriptionRenderer.vue @@ -237,10 +237,12 @@ export default { lastTranscriptBlock = transcriptBlock } - lastTranscriptBlock.chunks.push({ + const newTranscriptChunk = { message, languageId, - }) + } + + lastTranscriptBlock.chunks.push(newTranscriptChunk) this.$nextTick(() => { this.scrollToBottomLineByLine() From 7c8000f085975b1ff758bd49f55e4475c9b91af0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Tue, 2 Sep 2025 19:47:27 +0200 Subject: [PATCH 4/8] refactor: Split type for chunk and chunk element data MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Daniel Calviño Sánchez --- src/components/CallView/shared/TranscriptBlock.vue | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/components/CallView/shared/TranscriptBlock.vue b/src/components/CallView/shared/TranscriptBlock.vue index adf00c68e69..5767033720d 100644 --- a/src/components/CallView/shared/TranscriptBlock.vue +++ b/src/components/CallView/shared/TranscriptBlock.vue @@ -66,6 +66,11 @@ interface Chunk { languageId: string } +interface ChunkElementData { + message: string + languageId: string +} + export default { name: 'TranscriptBlock', @@ -167,7 +172,7 @@ export default { }, chunksWithSeparator() { - const chunksWithSeparator = [] as Array + const chunksWithSeparator = [] as Array if (!this.chunks.length) { return chunksWithSeparator From 8da135ec37ebc5bf5ba63b5175f91bd7b5f881d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Wed, 3 Sep 2025 04:51:50 +0200 Subject: [PATCH 5/8] refactor: Export and import type rather than defining it again MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Daniel Calviño Sánchez --- .../CallView/shared/LiveTranscriptionRenderer.vue | 6 +----- src/components/CallView/shared/TranscriptBlock.vue | 4 ++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/components/CallView/shared/LiveTranscriptionRenderer.vue b/src/components/CallView/shared/LiveTranscriptionRenderer.vue index f37b652962c..88883267c95 100644 --- a/src/components/CallView/shared/LiveTranscriptionRenderer.vue +++ b/src/components/CallView/shared/LiveTranscriptionRenderer.vue @@ -20,6 +20,7 @@