refactor(conversations): collapse updateConversationLocallyAndEmit into updateConversation

Since roomListFlow observes the database,
updateConversationLocallyAndEmit no longer emits anything itself - it
became identical to updateConversation apart from an unused user
parameter and a name promising a manual emission that no longer exists.
Remove it, point all call sites at updateConversation, and refresh the
interface docs that still described the manual-emission contract of
getRooms and roomListFlow.

Assisted-by: Claude Code:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Author: AndyScherzinger

app/src/main/java/com/nextcloud/talk/conversationlist/data/OfflineConversationsRepository.kt

@@ -16,7 +16,9 @@ import kotlinx.coroutines.flow.Flow
 interface OfflineConversationsRepository {
 
     /**
-     * Stream of a list of rooms, for use in the conversation list.
+     * Live stream of the observed account's conversations, for use in the conversation list.
+     * Backed by the local database: it re-emits whenever conversation rows change (room list
+     * sync, background catch-up, optimistic updates), with unchanged lists deduplicated.
      */
     val roomListFlow: Flow<List<ConversationModel>>
 
@@ -27,10 +29,9 @@ interface OfflineConversationsRepository {
     val conversationFlow: Flow<ConversationModel>
 
     /**
-     * Loads rooms from local storage. If the rooms are not found, then it
-     * synchronizes the database with the server, before retrying exactly once. Only
-     * emits to [roomListFlow] if the rooms list is not empty.
-     *
+     * Selects the account observed by [roomListFlow] and synchronizes its conversations with
+     * the server (when online). The synced changes surface through [roomListFlow], which
+     * observes the database.
      */
     @Deprecated("use observeConversation")
     fun getRooms(user: User): Job
@@ -42,10 +43,12 @@ interface OfflineConversationsRepository {
     @Deprecated("use observeConversation")
     fun getRoom(user: User, roomToken: String): Job
 
+    /**
+     * Updates a single conversation in the local database. [roomListFlow] observes the database
+     * and re-emits the updated list on its own.
+     */
     suspend fun updateConversation(conversationModel: ConversationModel)
 
-    suspend fun updateConversationLocallyAndEmit(user: User, conversation: ConversationModel)
-
     @Deprecated("use observeConversation")
     suspend fun getLocallyStoredConversation(user: User, roomToken: String): ConversationModel?
 

app/src/main/java/com/nextcloud/talk/conversationlist/data/network/OfflineFirstConversationsRepository.kt

@@ -154,10 +154,6 @@ class OfflineFirstConversationsRepository @Inject constructor(
         dao.updateConversation(entity)
     }
 
-    override suspend fun updateConversationLocallyAndEmit(user: User, conversation: ConversationModel) {
-        dao.updateConversation(conversation.asEntity())
-    }
-
     override suspend fun getLocallyStoredConversation(user: User, roomToken: String): ConversationModel? {
         val id = user.id!!
         return getConversation(id, roomToken)

app/src/main/java/com/nextcloud/talk/conversationlist/viewmodels/ConversationsListViewModel.kt

@@ -715,7 +715,7 @@ class ConversationsListViewModel @Inject constructor(
         val url = ApiUtils.getUrlForChatReadMarker(apiVersion, currentUser.baseUrl, conversation.token)
         viewModelScope.launch {
             withContext(Dispatchers.IO) {
-                repository.updateConversationLocallyAndEmit(currentUser, optimistic)
+                repository.updateConversation(optimistic)
             }
             try {
                 withContext(Dispatchers.IO) {
@@ -724,7 +724,7 @@ class ConversationsListViewModel @Inject constructor(
                 _readUnreadState.value = ConversationReadUnreadUiState.Success
             } catch (e: Exception) {
                 withContext(Dispatchers.IO) {
-                    repository.updateConversationLocallyAndEmit(currentUser, original)
+                    repository.updateConversation(original)
                 }
                 _readUnreadState.value = ConversationReadUnreadUiState.Error
             }
@@ -742,7 +742,7 @@ class ConversationsListViewModel @Inject constructor(
         val url = ApiUtils.getUrlForChatReadMarker(apiVersion, currentUser.baseUrl, conversation.token)
         viewModelScope.launch {
             withContext(Dispatchers.IO) {
-                repository.updateConversationLocallyAndEmit(currentUser, optimistic)
+                repository.updateConversation(optimistic)
             }
             try {
                 withContext(Dispatchers.IO) {
@@ -751,7 +751,7 @@ class ConversationsListViewModel @Inject constructor(
                 _readUnreadState.value = ConversationReadUnreadUiState.Success
             } catch (e: Exception) {
                 withContext(Dispatchers.IO) {
-                    repository.updateConversationLocallyAndEmit(currentUser, original)
+                    repository.updateConversation(original)
                 }
                 _readUnreadState.value = ConversationReadUnreadUiState.Error
             }
@@ -770,7 +770,7 @@ class ConversationsListViewModel @Inject constructor(
         val url = ApiUtils.getUrlForRoomFavorite(apiVersion, currentUser.baseUrl, conversation.token)
         viewModelScope.launch {
             withContext(Dispatchers.IO) {
-                repository.updateConversationLocallyAndEmit(currentUser, optimistic)
+                repository.updateConversation(optimistic)
             }
             try {
                 withContext(Dispatchers.IO) {
@@ -779,7 +779,7 @@ class ConversationsListViewModel @Inject constructor(
                 _favoriteState.value = FavoriteUiState.Success
             } catch (e: Exception) {
                 withContext(Dispatchers.IO) {
-                    repository.updateConversationLocallyAndEmit(currentUser, original)
+                    repository.updateConversation(original)
                 }
                 _favoriteState.value = FavoriteUiState.Error
             }
@@ -794,7 +794,7 @@ class ConversationsListViewModel @Inject constructor(
         val url = ApiUtils.getUrlForRoomFavorite(apiVersion, currentUser.baseUrl, conversation.token)
         viewModelScope.launch {
             withContext(Dispatchers.IO) {
-                repository.updateConversationLocallyAndEmit(currentUser, optimistic)
+                repository.updateConversation(optimistic)
             }
             try {
                 withContext(Dispatchers.IO) {
@@ -803,7 +803,7 @@ class ConversationsListViewModel @Inject constructor(
                 _favoriteState.value = FavoriteUiState.Success
             } catch (e: Exception) {
                 withContext(Dispatchers.IO) {
-                    repository.updateConversationLocallyAndEmit(currentUser, original)
+                    repository.updateConversation(original)
                 }
                 _favoriteState.value = FavoriteUiState.Error
             }

app/src/main/java/com/nextcloud/talk/conversationtags/viewmodels/ConversationTagsViewModel.kt

@@ -165,7 +165,7 @@ class ConversationTagsViewModel @Inject constructor(
         replaceConversationForTagAssignment(conversation.token, optimistic)
         viewModelScope.launch {
             withContext(Dispatchers.IO) {
-                repository.updateConversationLocallyAndEmit(currentUser, optimistic)
+                repository.updateConversation(optimistic)
             }
             try {
                 withContext(Dispatchers.IO) {
@@ -179,7 +179,7 @@ class ConversationTagsViewModel @Inject constructor(
             } catch (e: Exception) {
                 replaceConversationForTagAssignment(conversation.token, original)
                 withContext(Dispatchers.IO) {
-                    repository.updateConversationLocallyAndEmit(currentUser, original)
+                    repository.updateConversation(original)
                 }
                 Log.e(TAG, "Failed to assign conversation tags", e)
             }