Skip to content

ci(translations): Ensure there are no line breaks in strings #5788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Feb 2, 2026
+40 −2
Merged

ci(translations): Ensure there are no line breaks in strings #5788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ed2846
ci(translations): Ensure there are no line breaks in strings
nickvergessen Feb 2, 2026
8a8a51b
fix line break in string
sowjanyakch Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/workflows/lint-translations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
# SPDX-License-Identifier: MIT

name: Lint translation files

on:
pull_request:
branches: [ master, main, stable-* ]
push:
branches: [ master, main, stable-* ]

permissions:
contents: read

concurrency:
group: lint-php-cs-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
lint:
runs-on: ubuntu-latest-low

name: translations-string-xml

steps:
- name: Checkout
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
persist-credentials: false

- name: Check for new lines in translation strings
id: counter
run: |
grep -P '<string name' app/src/main/res/values/strings.xml | grep -vcP '</string>' | grep '^0$'

- name: Output
if: failure()
run: |
grep -P '<string name' app/src/main/res/values/strings.xml | grep -vP '</string>'
3 changes: 1 addition & 2 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,6 +930,5 @@ How to translate with transifex:
<string name="nc_scheduled_messages_empty">No scheduled messages</string>
<string name="nc_schedule_message_without_notification">Send later without notification</string>
<string name="nc_in_conversation">In %1$s</string>
<string name="no_scheduled_messages_offline">No connection to server - Scheduled messages could not be
loaded</string>
<string name="no_scheduled_messages_offline">No connection to server - Scheduled messages could not be loaded</string>
</resources>
Loading