[stable31] Migrate to playwright to update cypress #8230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

backportbot wants to merge 45 commits into stable31 from backport/8223/stable31

+1,505 −605

.eslintrc.cjs

-Original file line number
+Diff line change
@@ Expand Up / @@ -8,6 +8,16 @@ module.exports = { @@
     	extends: [
     		'@nextcloud',
     	],
+    	overrides: [
+    		{
+    			files: ['**/*.ts'],
+    			rules: {
+    				// Do not err out on constructors with parameter properties only.
+    				'no-useless-constructor': 'off',
+    				'@typescript-eslint/no-useless-constructor': 'error',
+    			},
+    		},
+    	],
     	rules: {
     		'@typescript-eslint/no-unused-vars': ['off'],
     		'import/no-unresolved': [1, { ignore: ['\\.svg\\?raw$'] }],
@@ Expand Down @@

.github/workflows/playwright.yml

-Original file line number
+Diff line change
@@ -0,0 +1,58 @@
+    # SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+    # SPDX-License-Identifier: MIT
+    name: Playwright Tests
+    on:
+      pull_request:
+        branches: [main]
+    jobs:
+      test:
+        timeout-minutes: 60
+        runs-on: ubuntu-latest
+        steps:
+          - name: Checkout app
+            uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+          - name: Check composer.json
+            id: check_composer
+            uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v2
+            with:
+              files: 'composer.json'
+          - name: Install composer dependencies
+            if: steps.check_composer.outputs.files_exists == 'true'
+            run: composer install --no-dev
+          - name: Read package.json node and npm engines version
+            uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
+            id: versions
+            with:
+              fallbackNode: '^20'
+              fallbackNpm: '^10'
+          - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
+            uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
+            with:
+              node-version: ${{ steps.versions.outputs.nodeVersion }}
+          - name: Set up npm ${{ steps.versions.outputs.npmVersion }}
+            run: npm i -g npm@"${{ steps.versions.outputs.npmVersion }}"
+          - name: Install node dependencies & build app
+            run: |
+              npm ci
+              TESTING=true npm run build --if-present
+          - name: Install Playwright Browsers
+            run: npx playwright install chromium --only-shell
+          - name: Run Playwright tests
+            run: npx playwright test
+          - uses: actions/upload-artifact@v5
+            if: always()
+            with:
+              name: playwright-report
+              path: playwright-report/
+              retention-days: 30

.gitignore

-Original file line number
+Diff line change
@@ Expand Up / @@ -8,11 +8,17 @@ cypress/snapshots/actual @@
     cypress/snapshots/diff
     cypress/videos/
     cypress/downloads/
+    /playwright-report/
     .php-cs-fixer.cache
+    /test-results/
     /tests/clover.xml
     /tests/.phpunit.result.cache
     dist/
     webpack-stats.json
     # js folder, to be updated wth --force
     /js
+    # Playwright snapshots - only keep the ci version in git
+    playwright/e2e/*-snapshots/**
+    !playwright/e2e/*-snapshots/*-on-ci-**

REUSE.toml

-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,7 @@ SPDX-FileCopyrightText = "Nils Adermann, Jordi Boggiano" @@
     SPDX-License-Identifier = "MIT"
     [[annotations]]
-    path = ["cypress/fixtures/**", "cypress/snapshots/**", "src/tests/fixtures/**", "src/tests/**/__snapshots__/**"]
+    path = ["cypress/fixtures/**", "cypress/snapshots/**", "playwright/support/fixtures/files/**", "playwright/e2e/*-snapshots/**", "src/tests/fixtures/**", "src/tests/**/__snapshots__/**"]
     precedence = "aggregate"
     SPDX-FileCopyrightText = "2019-2025 Nextcloud GmbH and Nextcloud contributors"
     SPDX-License-Identifier = "AGPL-3.0-or-later"
@@ Expand Down @@

cypress/e2e/SmartPicker.spec.js

This file was deleted.

cypress/e2e/mobile.spec.js

This file was deleted.

cypress/e2e/print.spec.js

This file was deleted.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable31] Migrate to playwright to update cypress #8230

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[stable31] Migrate to playwright to update cypress #8230

Are you sure you want to change the base?

[stable31] Migrate to playwright to update cypress #8230

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!