Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validateParameters function assigns (optionally) default values defined in the schema #35

Open
jfouret opened this issue May 27, 2024 · 1 comment

Comments

@jfouret
Copy link

jfouret commented May 27, 2024

Hi,

ValidateParameters will not define default values in case an option is null. As a results one need to write the default value at 2 places, in the config and in the schema without anything in place to sync it, this could be misleading in case only 1 value is changed in a future version of a pipeline.

I would suggest to add an option to the function that would set default values defined in the schema so that default values are defined and enforced from a single file.

I did not find anything related to this in the other issues, sorry if I missed something and if there is already something similar in place.

Bests,

@nvnieuwk
Copy link
Collaborator

nvnieuwk commented Aug 2, 2024

This is interesting! I'll need to explore a bit and see if it's possible but it does sound like a nice thing to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants