fix(table): custom with class names storybook styles #3344
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ankitts is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes in Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/components/table/stories/table.stories.tsx (3 hunks)
Additional comments not posted (6)
packages/components/table/stories/table.stories.tsx (6)
397-397: Updated text color for better visibility in light mode.This change standardizes the text color to
text-default-400, which should improve visibility in light mode while maintaining a neutral appearance in dark mode.
409-409: Text color consistency improved for team information.Aligning the text color of the team information with other text ensures uniformity and enhances readability across themes.
414-414: Standardized Chip component appearance.The use of a consistent class for the
Chipcomponent enhances the UI consistency across different statuses.
422-422: Uniform text styling for action icons.Ensuring that all action icons use the same text class
text-default-400helps maintain visual consistency across the application.Also applies to: 427-427
1036-1043: Updated table header styles for theme consistency.The introduction of specific classes for light and dark themes in the table header ensures that the header remains readable and stylistically consistent across both themes.
1047-1051: Enhanced table data styles for improved readability.Adjusting the text and border colors for table data cells to include theme-specific classes significantly improves text visibility in light mode and maintains clarity in dark mode.
wingkwong
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/components/table/stories/table.stories.tsx (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/components/table/stories/table.stories.tsx
Closes #3338
📝 Description
Currently the light mode version of Custom With Class Names Storybook style for tables is bad(text is not visible). This PR modifies the styling for light mode keeping the dark mode styles consistent.
⛳️ Current behavior (updates)
Old Light Mode
🚀 New behavior
New Light Mode
New Dark Mode
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Summary by CodeRabbit
Bug Fixes
Style