Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Alert title only string is supported #4525

Closed
coratgerl opened this issue Jan 9, 2025 · 2 comments · Fixed by #4529
Closed

[BUG] - Alert title only string is supported #4525

coratgerl opened this issue Jan 9, 2025 · 2 comments · Fixed by #4529
Assignees
@wingkwong
Labels
📦 Scope : Components Related to the components 🐛 Type: Bug Something isn't working

Comments

@coratgerl
Copy link

coratgerl commented Jan 9, 2025 •
edited
Loading

NextUI Version

2.6.11

Describe the bug

In the Alert on previous version we can put a React.ReactNode, now we can only set string, so we can do something like this:

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

 <Alert
              color="primary"
              title={<strong>Some content</strong>}
/>

Operating System Version

macOS

Browser

Chrome
@linear Linear
Copy link

linear bot commented Jan 9, 2025

ENG-1848 [BUG] - Alert title only string is supported

@wingkwong wingkwong self-assigned this Jan 10, 2025
@wingkwong
Copy link
Member

At this moment you could do the following. I'll investigate a bit on the code as i didn't see we could put React.ReactNode to title prop directly from the previous history.

<Alert color="primary">
  <strong>Some content</strong>
</Alert>

@wingkwong wingkwong mentioned this issue Jan 10, 2025
Merged
@wingkwong wingkwong added 🐛 Type: Bug Something isn't working 📦 Scope : Components Related to the components labels Jan 10, 2025
This was referenced Jan 13, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wingkwong wingkwong

Labels
📦 Scope : Components Related to the components 🐛 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(avatar): title type in Avatar heroui-inc/heroui
2 participants
@wingkwong @coratgerl