Skip to content

Commit 52722cc

Browse files
author
Mike Castle
committed
Remove the start() method from Service.
We are going to remove `start()` from `Page` soon, so it makes no sense to have a new use of it. Issue #130. ␄
1 parent e6b03e1 commit 52722cc

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

Diff for: linkedin-tool.user.js

-18
Original file line numberDiff line numberDiff line change
@@ -1668,11 +1668,6 @@
16681668
throw new Error(msg);
16691669
}
16701670

1671-
/** Called once when service is started. */
1672-
start() {
1673-
this.#notImplemented('start');
1674-
}
1675-
16761671
/** Called each time service is activated. */
16771672
activate() {
16781673
this.#notImplemented('activate');
@@ -1688,11 +1683,6 @@
16881683
/** Toy service for experimenting. */
16891684
class DummyService extends Service {
16901685

1691-
/** @inheritdoc */
1692-
start() {
1693-
this.logger.log('Dummy start');
1694-
}
1695-
16961686
/** @inheritdoc */
16971687
activate() {
16981688
this.logger.log('Dummy activate');
@@ -1719,11 +1709,6 @@
17191709
this.#scroller = scroller;
17201710
}
17211711

1722-
/** @inheritdoc */
1723-
start() {
1724-
this.logger.log('Scroller start, no-op');
1725-
}
1726-
17271712
/** @inheritdoc */
17281713
activate() {
17291714
this.#scroller.activate();
@@ -1839,9 +1824,6 @@
18391824
for (const shortcut of this.allShortcuts) {
18401825
this.#addKey(shortcut);
18411826
}
1842-
for (const service of this.#services) {
1843-
service.start();
1844-
}
18451827
}
18461828

18471829
/** @type {Shortcut[]} - List of {@link Shortcut}s to register. */

0 commit comments

Comments
 (0)