eslint: Bad use of globals

[nexushoratio]

Apparently there are some JS globals in the browser environment that are commonly used locals, like name, self, toolbar, and event. So tools like eslint that know about them will not flag them with no-undef. As a result, at least one minor cosmetic bug exists: Shortcuts do not get their name property set because the same named local variable was not set.

Not yet sure what the proper solution is.

Setting no-shadow.builtinGlobals = true is one solution, but that just disallows us from reusing that name, but not from accidentally using it.

Setting globals.name = off forces using it locally, but we are still shadowing it, and difficult to know about them. Maybe there is a way to disallow certain variables, and somehow keep it in sync with known globals.

Also, seems to be at least 59 existing cases of reusing a global variable, mostly name.

Removing browser from the environment would expose 17 currently functions, and it means that testing new browser functions would require manually updating the list. Or, always go through globalThis for everything, and have it be the only known global property.

• Create Exception class #259

[nexushoratio]

Dealing with name will be an interesting challenge.

One approach had been to disallow certain words as IDs. But, it turns out that eslint rule impacts not only variables, but field names as well. For those processed so far, was never an issue. But name is used all over the place. For instance, base.ensure().