-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroller
: navbar height can change
#240
Labels
Comments
nexushoratio
added
bug
Something isn't working
linkedin-tool
For the LinkedIn Tool userscript
labels
Feb 3, 2024
nexushoratio
changed the title
navbar height can change
Feb 7, 2024
Scroller
: navbar height can change
nexushoratio
pushed a commit
that referenced
this issue
Feb 8, 2024
First step in plumbing through detecting changes. Issue #240. ␄
nexushoratio
pushed a commit
that referenced
this issue
Feb 14, 2024
We now know that the values sometimes need to change after being initialized. Issue #240. ␄
nexushoratio
pushed a commit
that referenced
this issue
Feb 16, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 16, 2024
Rather than make yet another service, it is probably appropriate to roll this into This does leave secondary We can worry about that detail later, but to capture some initial thoughts:
|
nexushoratio
pushed a commit
that referenced
this issue
Feb 18, 2024
Alas, it will no longer be generic. Issue #240. ␄
nexushoratio
pushed a commit
that referenced
this issue
Feb 19, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 23, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 25, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 26, 2024
Upcoming changing will make this field optional (e.g., secondary `Scroller`s). Issue #240. ␄
nexushoratio
pushed a commit
that referenced
this issue
Feb 26, 2024
nexushoratio
pushed a commit
that referenced
this issue
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the page resizes, the text "For Business", can wrap, increasing the height of the navbar, throwing everything off.
Bah.
Dispatcher
for thisScroller
to take changesService
ScrollerService
LinkedIn
should expose #globals.Scroller
: navbar height can change #240 (comment)Scroller
via setter, empty sets to nullLinkedInToolbarService
?)LinkedIn.navbarScrollerFixup()
The text was updated successfully, but these errors were encountered: