-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroller
: Add click() feature
#241
Open
9 of 13 tasks
Labels
enhancement
New feature or request
library
For libraries
linkedin-tool
For the LinkedIn Tool userscript
Comments
nexushoratio
added
enhancement
New feature or request
linkedin-tool
For the LinkedIn Tool userscript
library
For libraries
labels
Feb 4, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 8, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 12, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 14, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 16, 2024
Makes it a little bit easier to read. E.g., for "Events events" was... Issue #241. ␄
nexushoratio
pushed a commit
that referenced
this issue
Feb 18, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 19, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 23, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 23, 2024
nexushoratio
pushed a commit
that referenced
this issue
Feb 26, 2024
nexushoratio
pushed a commit
that referenced
this issue
Mar 4, 2024
Was getting a bit long. Issue #241. ␄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
library
For libraries
linkedin-tool
For the LinkedIn Tool userscript
When working on the focus UX change, we discovered that focusOnElement() is broken by design. When an element that does not generally support focus (e.g.,
<div>
) is used, andtabindex
is taken away, focus goes back to document.body. Though, depending on browser,TAB
to the next field will work as expected.A common
Shortcut
is to somehow select the current item, often usingEnter
. After much exploring, it would probably work like:In some cases, handleLocally() would be a call to clickElement(), sometimes with
matchSelf = True
, sometimes not. In one, it is a complicated function that depends on context.In all cases, if unable to find something to click, postInfoAboutElement() is called.
Not yet clear if should just always be a function (like uidCallback) that returns an element, or a selector list/matchSelf object that would get passed to clickElement(), or support both. Would probably end up being both.
Scroller~How
with click config property, defaultnull
Enter
config === null
, callNH.base.issues.post()
about programming errorHTMLElement
, returns{?HTMLElement}
, if null, callpostInfoAboutElement(item)
false
, callpostInfoAboutElement(item)
(ClickConfig|ElementFinder)
be consistent with how base/selectors vs containerItems are handledEnter
MyNetwork.viewItem
Jobs.activateJob
(renameviewJob
?)Notifications.activateNotification
(renameNo, because it may cause a message pop-up)viewNotification
?Issue #232 can be used to decide about utilizing this else where.
The text was updated successfully, but these errors were encountered: