Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to reconnect the LIT menu on certain pages #242

Open
nexushoratio opened this issue Feb 5, 2024 · 3 comments
Open

Need to reconnect the LIT menu on certain pages #242

nexushoratio opened this issue Feb 5, 2024 · 3 comments
Labels
bug Something isn't working linkedin-tool For the LinkedIn Tool userscript

Comments

@nexushoratio
Copy link
Owner

nexushoratio commented Feb 5, 2024 •
edited
Loading

This is a followup to #220, with a reproducible case.

https://www.linkedin.com/events/

If the site is loaded with that link, there is a visible delay rendering the nav menu. In particular, the For Business and Learning menu items show up later. This happens even without userscripts.

If we can figure out what is happening, great. Otherwise, the reconnecting happens as intended and maybe the posting on issue should go away. (Fortunately the posting only happens in dev mode.)
@nexushoratio nexushoratio added bug Something isn't working linkedin-tool For the LinkedIn Tool userscript labels Feb 5, 2024
@nexushoratio nexushoratio self-assigned this Feb 5, 2024
@nexushoratio
Copy link
Owner Author

Adding an additional wait for a footer sometimes help, but, as noticed with #220, not always.

It definitely seems like the For Business and Learning items show up much later.

@nexushoratio
Copy link
Owner Author

A fix is in place. We will let it burn in for a while, and if it works out, will do a subsequent cleanup.

@nexushoratio nexushoratio removed their assignment Feb 7, 2024
nexushoratio pushed a commit that referenced this issue Feb 8, 2024
Wait for the *For Business* menu item to show up.
ef704a1 
Identified by the `--divider` subclass, on some pages, this item gets added
later.  Actually, the entire navbar content gets rebuilt, causing us to have
to reconnect the LIT menu button.

If this pans out, we can make it the official item, simplifying this code.

Issue #242.

␄
@nexushoratio nexushoratio self-assigned this Mar 13, 2024
@nexushoratio
Copy link
Owner Author

Unable to verify at this time. Will queue up again for observation.

@nexushoratio nexushoratio removed their assignment Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working linkedin-tool For the LinkedIn Tool userscript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nexushoratio