Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize the uniqueFooIdentifier() functions #251

Open
7 tasks
Tracked by #250
nexushoratio opened this issue Feb 12, 2024 · 0 comments
Open
7 tasks
Tracked by #250

Normalize the uniqueFooIdentifier() functions #251

nexushoratio opened this issue Feb 12, 2024 · 0 comments
Labels
cleanup This doesn't seem right, refactor, etc linkedin-tool For the LinkedIn Tool userscript

Comments

@nexushoratio
Copy link
Owner

nexushoratio commented Feb 12, 2024

A bit all over the place.

  • We should figure out if using if (element) {...} defensively, or not
  • Probably always start with let content = element.innerText;, then fine tune
  • Normalize name if always include associated Scroller (or Shared in the exceptional case of Feed)
  • Use of Logger as this will always refer to the Scroller this here (no need to use the global)
    • Always intro/outro for element/content
    • Experiment: Can const me = Class.method.name work, instead of strings (something recently used in an unrelated Apps Script)
  • Document above in STYLE-GUIDE
@nexushoratio nexushoratio added cleanup This doesn't seem right, refactor, etc linkedin-tool For the LinkedIn Tool userscript labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup This doesn't seem right, refactor, etc linkedin-tool For the LinkedIn Tool userscript
Projects
None yet
Development

No branches or pull requests

1 participant