Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up tests that use RegExp for HTML #254

Open
Tracked by #250
nexushoratio opened this issue Feb 18, 2024 · 0 comments
Open
Tracked by #250

Clean up tests that use RegExp for HTML #254

nexushoratio opened this issue Feb 18, 2024 · 0 comments
Labels
cleanup This doesn't seem right, refactor, etc library For libraries

Comments

@nexushoratio
Copy link
Owner

Was always a Bad Idea(tm). But, it recently bit us with a bug.
@nexushoratio nexushoratio added cleanup This doesn't seem right, refactor, etc library For libraries labels Feb 18, 2024
@nexushoratio nexushoratio mentioned this issue Feb 18, 2024
Open
9 tasks
nexushoratio pushed a commit that referenced this issue Feb 19, 2024
General improvements to use of RegExp in tests.
654c2d1 
The recent experience with an overly forgiving expression suggests another
look at the whole set of tests, particularly the use of `.*`.

Hoisted the GUID expression to the file level and used in a few other
locations.

It is well known that using RegExp with HTML is generally a Bad Idea(tm).
These tests really should be rewritten to compare at the DOM level.

Issues #190, #254.

␄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup This doesn't seem right, refactor, etc library For libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nexushoratio