-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide replicate information explicitly in samplesheet #343
Comments
I'm not sure if there has been any input on this, but we have several ChIP-Seq projects that have biological reps, so having some way to keep track of these and perform IDR would be great. |
In the short term, couldn't replicates be captured when checking the sample sheet, then used downstream? Around this spot: chipseq/bin/check_samplesheet.py Line 80 in 51eba00
|
The |
Yep, missed that. I definitely like having the explicit column for this better than the |
Closed by #349 |
Description of feature
Currently, the pipeline considers as a biological replicate any sample which has the same id under the
sample
column of the samplesheet followed by a different suffix determined by an underscore e.g.:This information is used by the pipeline in this code line to determine whether multiple groups are present e,g,
sample1
andsample2
in the example above and whether replicates existsr1
andr2
also using the example above.However, the problem with this approach is that is based on the sample names and sometimes this can be problematic since depends on the correct naming of the replicates with the underscore, see this issue.
I guess that the solution to this problem will be to include again the
replicate
column into the samplesheet, although this information is currently only used for enabling the run ofDESEQ2_QC
here andMACS2_CONSENSUS
here.I would like to know your opinion here @drpatelh, @bjlang and any other willing to give feedback of course :smi
The text was updated successfully, but these errors were encountered: