Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paired end bug #145

Merged
merged 5 commits into from
May 29, 2024
Merged

Fix paired end bug #145

merged 5 commits into from
May 29, 2024

Conversation

mirpedrol
Copy link
Member

When I introduced the ability to use the meta map key single_end I changed the value for some channels. This made it impossible to join those channels with the original ones as they had different metas.
This PR removes the single_end from the meta map to be able to join the channels. It also changes the value from reference, template, and protospacer channels accordingly.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 081ca39

+| ✅ 222 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.2.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_exist - File is ignored: conf/test.config
  • files_exist - File is ignored: conf/test_full.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-29 08:32:20

@LaurenceKuhl
Copy link
Contributor

LGTM but maybe you could comment the channel magic a little bit more? :D

mirpedrol
mirpedrol commented May 29, 2024
View reviewed changes
workflows/crisprseq_targeted.nf Show resolved Hide resolved
workflows/crisprseq_targeted.nf Show resolved Hide resolved
workflows/crisprseq_targeted.nf Show resolved Hide resolved
workflows/crisprseq_targeted.nf Show resolved Hide resolved
workflows/crisprseq_targeted.nf Show resolved Hide resolved
@mirpedrol mirpedrol merged commit c8a2179 into nf-core:dev May 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenceKuhl LaurenceKuhl LaurenceKuhl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @LaurenceKuhl