Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation describing day0 label #165

Closed
jeremymsimon opened this issue Jul 5, 2024 · 1 comment
Closed

Improve documentation describing day0 label #165

jeremymsimon opened this issue Jul 5, 2024 · 1 comment
Labels
enhancement Improvement for existing functionality

Comments

@jeremymsimon
Copy link

Description of feature

I've read the crisprseq and MAGeCK documentation a few times and the description and function of the day0_label is still a bit unclear to me, both in terms of how it should be specified (especially if there are multiple control samples/replicates) and what specifically it does.

Let's say I have 3 control samples, and 3 treated samples, should the day0_label be set to control as is specified in my contrasts? Or should it be a comma-separated list of e.g. Control_Rep1,Control_Rep2,Control_Rep3? Or is it only appropriate for a true time-course experiment?

Further, according to the MAGeCK documentation the day0 label is a required parameter, but it does not seem to be required for crisprseq to run--I get MAGeCK counts and MLE results regardless. Is it figuring out a label automatically based on the contrasts, or is this a bug?

Thanks!

@jeremymsimon jeremymsimon added the enhancement Improvement for existing functionality label Jul 5, 2024
@LaurenceKuhl
Copy link
Contributor

Hi @jeremymsimon this is normally now more thoroughly described, if you still find it confusing feel free to re open this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants