Use collect and confirm strategy for tests

Replace Nextflow versioning with simple list matrix

Author: adamrtalbot

.github/workflows/ci.yml

@@ -32,8 +32,6 @@ jobs:
     steps:
       - name: Install Nextflow
         uses: nf-core/setup-nextflow@v1
-        with:
-          version: "${{ matrix.NXF_VER }}"
 
       - name: Cache nf-test installation
         id: cache-software
@@ -99,29 +97,31 @@ jobs:
         run: |
           echo ${{ steps.list.outputs.tags }}
 
-  define_nxf_versions:
-    name: Choose nextflow versions to test against depending on target branch
-    runs-on: ubuntu-latest
-    outputs:
-      matrix: ${{ steps.nxf_versions.outputs.matrix }}
-    steps:
-      - id: nxf_versions
-        run: |
-          if [[ "${{ github.event_name }}" == "pull_request" && "${{ github.base_ref }}" == "dev" && "${{ matrix.NXF_VER }}" != "latest-everything" ]]; then
-            echo matrix='["latest-everything"]' | tee -a $GITHUB_OUTPUT
-          else
-            echo matrix='["latest-everything", "23.04.0"]' | tee -a $GITHUB_OUTPUT
-          fi
+  # define_nxf_versions:
+  #   name: Choose nextflow versions to test against depending on target branch
+  #   runs-on: ubuntu-latest
+  #   outputs:
+  #     matrix: ${{ steps.nxf_versions.outputs.matrix }}
+  #   steps:
+  #     - id: nxf_versions
+  #       run: |
+  #         if [[ "${{ github.event_name }}" == "pull_request" && "${{ github.base_ref }}" == "dev" && "${{ matrix.NXF_VER }}" != "latest-everything" ]]; then
+  #           echo matrix='["latest-everything"]' | tee -a $GITHUB_OUTPUT
+  #         else
+  #           echo matrix='["latest-everything", "23.04.0"]' | tee -a $GITHUB_OUTPUT
+  #         fi
 
   test:
     name: ${{ matrix.tags }} ${{ matrix.profile }} NF-${{ matrix.NXF_VER }}
-    needs: [changes, define_nxf_versions]
+    needs: [changes]
     if: needs.changes.outputs.changes
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        NXF_VER: ${{ fromJson(needs.define_nxf_versions.outputs.matrix) }}
+        NXF_VER:
+          - "latest-everything"
+          - "23.04"
         tags: ["${{ fromJson(needs.changes.outputs.tags) }}"]
         profile:
           - "docker"
@@ -180,3 +180,21 @@ jobs:
         if: always() # always run even if the previous step fails
         with:
           report_paths: test.xml
+
+  confirm-pass:
+    runs-on: ubuntu-latest
+    needs: [test]
+    if: always()
+    steps:
+      - name: All tests ok
+        if: ${{ success() || !contains(needs.*.result, 'failure') }}
+        run: exit 0
+      - name: One or more tests failed
+        if: ${{ contains(needs.*.result, 'failure') }}
+        run: exit 1
+
+      - name: debug-print
+        if: always()
+        run: |
+          echo "toJSON(needs) = ${{ toJSON(needs) }}"
+          echo "toJSON(needs.*.result) = ${{ toJSON(needs.*.result) }}"