-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download: Seqera container support - Patch 1 #3244
Download: Seqera container support - Patch 1 #3244
Conversation
…ontainers and write additional test.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this resolution, we appreciate you :-)
Co-authored-by: Matthias Hörtenhuber <[email protected]>
This PR extends the tests so that Seqera Container support is tested for. It also tweaks the symlink function to support the unconventional registry that Seqera Containers uses.
This is a basic patch. It does neither add
oras://
support nor does it fix the issue with the container priority resolution (#3179). For modules using Seqera containers, nf-core download will always download both containers, the native Singularity one and convert the Docker container to Singularity as well.PR checklist
CHANGELOG.md
is updateddocs
is updated