Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artic v5 mismatched primer names in artic-ncov2019 repo cause certain amplicons to be erroneously filtered/removed #392

Open
Sam-Sims opened this issue Aug 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Sam-Sims
Copy link

Sam-Sims commented Aug 18, 2023

Description of the bug

Hello!

By default viralrecon pulls the Artic V5 bed file from: https://github.com/artic-network/artic-ncov2019/raw/master/primer_schemes/nCoV-2019/V5.3.2/SARS-CoV-2.scheme.bed

However in this version of the bed file, the primer names are mismatched for the following pairs:
SARS-CoV-2_3
SARS-CoV-2_31
SARS-CoV-2_62
SARS-CoV-2_89
SARS-CoV-2_96

This results in reads belonging to those pairs being erroneously filtered out as part of artic minion, and are consequently removed from the primertrimmed.rg.sorted.bam file. This results in amplicons appearing "dropped" for those regions, even though there is coverage. I have outlined this issue in more detail here: artic-network/fieldbioinformatics#126

The current workaround I have found is to manually use the bed file from artic-network/primer-schemes : https://github.com/artic-network/primer-schemes/blob/master/nCoV-2019/V5.3.2/SARS-CoV-2.scheme.bed

This means removing the sequences in the bed file as the collapse_primer_bed.py script expects 6 columns:
line 58: chrom, start, end, name, score, strand = line.strip().split("\t")

I think this would affect everyone using the Artic V5 scheme and viralrecon currently. It might be useful to use the bed file in artic-network/primer-schemes for now, and modify collapse_primer_bed.py to handle the sequence column?

Would be happy to open a PR - but think the config needs to be changed in the nf-core/configs repo to modify the download url?

Thanks,
Sam

Command used and terminal output

No response

Relevant files

No response

System information

No response

@Sam-Sims Sam-Sims added the bug Something isn't working label Aug 18, 2023
@Sam-Sims Sam-Sims changed the title Artic v5 mismatched primer names different repos cause amplicons to be "dropped" Artic v5 mismatched primer names in different repos cause amplicons to be "dropped" Aug 18, 2023
@Sam-Sims Sam-Sims changed the title Artic v5 mismatched primer names in different repos cause amplicons to be "dropped" Artic v5 mismatched primer names in artic-ncov2019 repo cause amplicons to be "dropped" Aug 18, 2023
@Sam-Sims Sam-Sims changed the title Artic v5 mismatched primer names in artic-ncov2019 repo cause amplicons to be "dropped" Artic v5 mismatched primer names in artic-ncov2019 repo cause certain amplicons to be erroneously filtered/removed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant