Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly deal with multiqc in the config files before the next release #411

Open
maxulysse opened this issue Jan 16, 2024 · 3 comments
Open
Labels
enhancement Improvement for existing functionality
Milestone

Comments

@maxulysse
Copy link
Member

Description of feature

cc @adamrtalbot @svar

@maxulysse maxulysse added the enhancement Improvement for existing functionality label Jan 16, 2024
@maxulysse maxulysse added this to the 2.7 milestone Jan 16, 2024
@adamrtalbot
Copy link

Could we have a little explanation? I don't really know what this refers to.

@svarona
Copy link
Contributor

svarona commented May 10, 2024

Hi again! Correct me if I'm wrong @maxulysse, but I think @adamrtalbot, this is related to the problem that viralrecon has two workflows, each of them with its .config file in conf folder. So each time nf-core-tools are updated, TEMPLATE branch will update MULTIQC in the conf/modules.config file instead of in each of the workflow's config files modules_nanopore.config and modules_illumina.config. Isn't it?

Have you been working on this already?

@maxulysse
Copy link
Member Author

Sorry, I missed @adamrtalbot's comment many moons ago.
What I meant was since we have 2 workflows, why don't we try to run multiQC just once as an after step in the NFCORE_VIRALRECON workflow from the main main.nf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants